Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Trond Myklebust" <trondmy@hammerspace.com>
Cc:     linux-nfs@vger.kernel.org, anna.schumaker@netapp.com
Subject: Re: client skips revalidation if holding a delegation
Date:   Tue, 11 Jun 2019 13:01:43 -0400
Message-ID: <53641A5A-1888-4864-B48A-69D73DB000C0@redhat.com>
In-Reply-To: <2cc7cbfda42601d2e52ee63bed2dbb4140401adc.camel@hammerspace.com>
References: <6C2EF3B8-568A-41F0-B134-52996457DD7D@redhat.com>
 <c133a2ed862bf5714210aa5a44190ddaecfa188f.camel@hammerspace.com>
 <CFD3CE5E-5081-4A4D-B67E-41D9E7A3D5C5@redhat.com>
 <a595b6962b2e083fef8ad2d3534e1d0964995560.camel@hammerspace.com>
 <7289561F-686E-4425-B0CE-F3E5800C033D@redhat.com>
 <243407AC-A416-4FF2-A09B-B1362C6206D9@redhat.com>
 <2cc7cbfda42601d2e52ee63bed2dbb4140401adc.camel@hammerspace.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On 10 Jun 2019, at 12:43, Trond Myklebust wrote:

> On Mon, 2019-06-10 at 10:14 -0400, Benjamin Coddington wrote:
>> On 4 Jun 2019, at 15:00, Benjamin Coddington wrote:
>>
>>> At least now I can spend some time on it and not feel aimless,
>>> thanks for
>>> the closer look.
>>
>> I am not finding a reliable way to fix this and retain the
>> optimization.  I
>> will send a patch to remove it.
>
>
> How about just moving the optimisation into the if
> (nfs_check_verifier()) { } case? There should be no need to do the
> nfs_lookup_verify_inode() dance if we hold a delegation. should there?

Ok, right -- we can optimize that away..  I'll see what sticks to the wall.

Ben