Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH 3/3] mountstats: Check for RPC iostats version >= 1.1 with
 error counts
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20190613120314.1864-3-dwysocha@redhat.com>
Date:   Wed, 19 Jun 2019 12:35:00 -0400
Cc:     Steve Dickson <SteveD@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD291454-53BB-46DB-BEBE-9AA2F8DE18DE@oracle.com>
References: <20190612190229.31811-1-dwysocha@redhat.com>
 <20190613120314.1864-1-dwysocha@redhat.com>
 <20190613120314.1864-3-dwysocha@redhat.com>
To:     Dave Wysochanski <dwysocha@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Jun 13, 2019, at 8:03 AM, Dave Wysochanski <dwysocha@redhat.com> =
wrote:
>=20
> Add explicit check for statsvers instead of array based check.

Hi Dave,

I don't understand why this change is necessary. The patch description
should explain.


> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
> ---
> tools/mountstats/mountstats.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/mountstats/mountstats.py =
b/tools/mountstats/mountstats.py
> index 5f13bf8e..2ebbf945 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -476,7 +476,7 @@ class DeviceData:
>                 if retrans !=3D 0:
>                     print('\t%d retrans (%d%%)' % (retrans, ((retrans =
* 100) / count)), end=3D' ')
>                     print('\t%d major timeouts' % stats[3], end=3D'')
> -                if len(stats) >=3D 10 and stats[9] !=3D 0:
> +                if self.__rpc_data['statsvers'] >=3D 1.1 and stats[9] =
!=3D 0:
>                     print('\t%d errors (%d%%)' % (stats[9], ((stats[9] =
* 100) / count)))
>                 else:
>                     print('')
> --=20
> 2.20.1
>=20

--
Chuck Lever