Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2021149ybi; Thu, 20 Jun 2019 07:52:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8PS7yg6GZF+opXVbY6skKVvgZWZMuiK0wv2WK1lP/7imAreRjxO7Jnpz1P14liXAtZUeZ X-Received: by 2002:a17:902:20e2:: with SMTP id v31mr124991040plg.138.1561042349579; Thu, 20 Jun 2019 07:52:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561042349; cv=none; d=google.com; s=arc-20160816; b=AS6YAYTu85yUwCBYcyaq8qcg8CLwGWlMqjCz/3zyTNxOV95IxkeugS7beB0rD1n5wZ euzPRpCMOKTQjwGu+mXOHQtkhTEKYYcrht/OES/+6KRTEi3k3ITZdRPoP1Fn5j/a2nYH n0DEpfr3BPoGPKjUYg3jdHNDrMixcmlmJaSAm5CTUlVg0eSNcBb/b6vZ5JhzzYeB8Tzb K0uwOGT6RVVnf37wpIgs2IcaQAWRWawEI9grPFiZqSCGcz4hecjKIMEx/XsDaN24KB/i xVhCfMkDaFNCvNqlLMkiSHE95qsSfYfygtAc/Uli+udiIjneEwzND8umuN3VtvquITLZ gASA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ydej7i7/4qpUHRehYnPSCprmqgd6lNGRHyp3hRvYxr0=; b=QMMkmfLqK1CDxZsIX8K6NDvEX/ou90VCm1VfpB1DLoqnkmVwwCq2hvsDQGz2Q/bPTT 0VaJXg14aj33br7/j2059Nunh09YKTdn4jNdMOj08zxiTJ0jz0DUoYU/aiGPry/jnIyG sfmygusTS5NsXGMXhJRhQ9b/ZiCuppMUixUx3p+jXajgA9yT+izLFdhwXUl0ouovN+n6 E/Owc7VASymZTziPs4XaI7o5VvH5rafmC3jMruESeU+xiRSlRpNRhKpLuCAsXyXZf3ih QFYmX84ltKTB+IaBjcQt03IbuiZYVeGVeVfP+fkayqix/nmpez8KmYx2iav/TYd8DxnG 2eig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3si19290394pfr.27.2019.06.20.07.52.16; Thu, 20 Jun 2019 07:52:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbfFTOv0 (ORCPT + 99 others); Thu, 20 Jun 2019 10:51:26 -0400 Received: from fieldses.org ([173.255.197.46]:43456 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfFTOvW (ORCPT ); Thu, 20 Jun 2019 10:51:22 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 1EF046081; Thu, 20 Jun 2019 10:51:21 -0400 (EDT) From: "J. Bruce Fields" To: linux-nfs@vger.kernel.org Cc: "J. Bruce Fields" Subject: [PATCH 07/16] nfsd: copy client's address including port number to cl_addr Date: Thu, 20 Jun 2019 10:51:06 -0400 Message-Id: <1561042275-12723-8-git-send-email-bfields@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1561042275-12723-1-git-send-email-bfields@redhat.com> References: <1561042275-12723-1-git-send-email-bfields@redhat.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: "J. Bruce Fields" rpc_copy_addr() copies only the IP address and misses any port numbers. It seems potentially useful to keep the port number around too. Signed-off-by: J. Bruce Fields --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index d3de89dacf89..dd89dc05f6ee 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -2273,7 +2273,7 @@ static struct nfs4_client *create_client(struct xdr_netobj name, clp->cl_time = get_seconds(); clear_bit(0, &clp->cl_cb_slot_busy); copy_verf(clp, verf); - rpc_copy_addr((struct sockaddr *) &clp->cl_addr, sa); + memcpy(&clp->cl_addr, sa, sizeof(struct sockaddr_storage)); clp->cl_cb_session = NULL; clp->net = net; clp->cl_nfsd_dentry = nfsd_client_mkdir(nn, &clp->cl_nfsdfs, -- 2.21.0