Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp3255875ybd; Fri, 28 Jun 2019 05:37:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJ7KFulMRLlmn0+4OH/oPct4vWNdkiObMF4GEpUlmLELrhq+mlo/KX7T1yEOubSAtBku7x X-Received: by 2002:a17:90a:24ac:: with SMTP id i41mr12883874pje.124.1561725443160; Fri, 28 Jun 2019 05:37:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561725443; cv=none; d=google.com; s=arc-20160816; b=TGYp1wjfjbGV0t/q5itnasDz/nnQSC/aDC4nGdncXzkzKjO9d/rFfQE+1a1ayIRqWg YBWo3+R8/sagjMzRTNayj5FDzfc7IOMqm6qsGAsHVwE8L8xkVUfcVs+I17MpEaf/qDUm SoXSF+vnSwyD0lszppGVMl69MUFB5Kkeuv7hzedtaMaAdT5ny7jqW0VLzMxklkGAf7I9 2ux4Pj3VBGxzEosywqmQa32TSPNsNzEXAq2PrSR7B96GFkX5+3i7/cUqHuTVSZx+Q90T p8KtZp78FiFkDcT4LItqpByPwMtkeXDQSliecC0Ob7K7Dwg1kdiFswO4yWV7GO9NEDDQ HdfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=WNL4c5WBuqv/sRfsceIYJxZ7aQLCnpdVTV6VEHbC118=; b=hcTGx6DBmqJI+AjqOeUXw3WqNspXMsm/miqeKr+dtcWns13oE+nhrBnFUJEC4BpCWD vk0pXTcvOP1PLoV3Nk6REgW0iRdMCpfXeYhVok8YEXv1C8e0vuK3vmhGyBGS3EDNAYbh FKRHesBMddU+AQC+l+0QfSS5P2zpltt4wPkEA92Zq8uT3obLY2phL3/h0VUQiYeol9j6 tAkzJuVhcYZ5UgPDQc0bJyYJMxR0x6HcZKbVkpOiae59AxpX63NlhTaDzSG5tg5/8s5L TDbv9vFmZhM2RzmhAb4weUsOcj7mhBeY3hRralNosfjOWLuJJL+/lrM4KOYYvqh7koQS z84g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si2117044plb.39.2019.06.28.05.37.01; Fri, 28 Jun 2019 05:37:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbfF1Mg7 (ORCPT + 99 others); Fri, 28 Jun 2019 08:36:59 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:39019 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726578AbfF1Mg7 (ORCPT ); Fri, 28 Jun 2019 08:36:59 -0400 Received: from theinternet.molgen.mpg.de (theinternet.molgen.mpg.de [141.14.31.7]) by mx.molgen.mpg.de (Postfix) with ESMTP id D4A152000C012; Fri, 28 Jun 2019 14:36:57 +0200 (CEST) From: Donald Buczek To: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com Cc: Donald Buczek Subject: [PATCH 0/4 RESEND] nfs4.0: Refetch lease_time after clientID reset Date: Fri, 28 Jun 2019 14:36:36 +0200 Message-Id: <20190628123640.8715-1-buczek@molgen.mpg.de> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org (rebased on linux-next) We've noticed, that nfs mounts with vers=4.0 do not pick up a updated lease_time after a restart of the nfs server. This was discussed in the thread "4.0 client and server restart with decreased lease time" on linux-nfs [1]. This patch set fixes the issue for nsf4.0 clients so that hey behave as nfs4.1 and nfs4.2 clients do. After a new clientID is established, the lease_time is re-fetched and used. I've notcied, that the flag NFS_CS_CHECK_LEASE_TIME is not functional in the existing code. It is set and tested, but never reset. Either nfs4_setup_state_renewal should reset the flag after it verified the lease_time or the flag could be removed altogether. I left it as is, because I don't known what is preferred. [1] https://marc.info/?t=154954022700002&r=1&w=2 Donald Buczek (4): nfs: Fix copy-and-paste error in debug message nfs4: Rename nfs41_setup_state_renewal nfs4: Move nfs4_setup_state_renewal nfs4.0: Refetch lease_time after clientid update fs/nfs/nfs4state.c | 46 +++++++++++++++++++++++----------------------- fs/nfs/nfs4xdr.c | 2 +- 2 files changed, 24 insertions(+), 24 deletions(-) -- 2.21.0