Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8772735ybi; Tue, 9 Jul 2019 22:57:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYC3zU4NXdRckrC2fJjh6O9+Lh9xSjcvtZZISKm99XUz2bkakxnwmf+z9pH6LA57WIxuG2 X-Received: by 2002:a63:607:: with SMTP id 7mr8940384pgg.240.1562738250644; Tue, 09 Jul 2019 22:57:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562738250; cv=none; d=google.com; s=arc-20160816; b=LwqEDewVBROMHROSVNT2QjtOIiDXWrnLmusqnwbdciwzaSt1G0N71TuRbwboWN2xcv gRE44hYrbgDcFM51Oemc6tLuFoklTsBI3d9lbl0N5OwnlpUdKeLQ1S3XNcIrObYAQQwQ vLccJYU5iguDXl276c81yrRjNqXTyD8N/MZbNMxTkvsvBSt9B5C6YA2un17iETqRXwEE JnqWeaHl5X0UB3VxVGOoyLUp5Ro3eMhRxBhWvFx4Z2ZdmIrMPbo8TlFpTm+Gr++8wajk yejl2bnIEBpiyh14LecAbkg44NzrdWUz1x078jaPXSL2J8nLT8Bzpo1eixF3uL5g9c2i PaLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wQd0m51bohQ8PyKE/R/WhD/2YjeHkTMSJzj2kH0U9Xs=; b=UmlnUeUErzExLKlhU4Scp85QM8jViLYMfmARnB/ztnM3y5ajSnWMSAapAxc3O5qfol 3p+tgrgOlSoM52JWs6FfNkyn1uft5GHsKVt8aiE88fAu9c3L3f+qg1Ia8l+4ezw21wrL dRFehQpXOxP8sJp967/GrUWVltQ/ZrdrbIqhLL8k896yBgLVwwHTJ5FpO+BX2jTqsSw/ XSNbxfmMcritGXOh6FP8NQah7NLwpezwXSuHINnc0/4EASoeEV8bdffoOE8I3gLA0R36 vLNMJcNgagaGmZx5ujU8yg6wL/r4Mbyi4RXt0YzlMjczTugZ6gxqe17AaZt3Oaq2Cu4g PETA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUi3f2ia; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e92si1182953pld.312.2019.07.09.22.57.17; Tue, 09 Jul 2019 22:57:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUi3f2ia; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbfGJF4b (ORCPT + 99 others); Wed, 10 Jul 2019 01:56:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:60892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbfGJF4b (ORCPT ); Wed, 10 Jul 2019 01:56:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B65F720838; Wed, 10 Jul 2019 05:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562738191; bh=V9iaENcRfclKrRlxtMr6FYwVEOvk/HuSF0jjt+eARO4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iUi3f2iayn9lfkE/YOYo0Yov3kvzO7+KOEyaS9Fml7JycwWRssHNDg7wVhtU5esPw EoM52iaiWfmiaPubKM1oCY3H+8qeExOy+hWruR3E06hQYBobvtIjycEbSPoCRnbB/Z +wlk3mSulTMRn5+41mKp91hHlSbguwHX7MgqGniE= Date: Wed, 10 Jul 2019 07:56:28 +0200 From: Greg KH To: Xiaoming Ni Cc: adobriyan@gmail.com, akpm@linux-foundation.org, anna.schumaker@netapp.com, arjan@linux.intel.com, bfields@fieldses.org, chuck.lever@oracle.com, davem@davemloft.net, jlayton@kernel.org, luto@kernel.org, mingo@kernel.org, Nadia.Derbey@bull.net, paulmck@linux.vnet.ibm.com, semen.protsenko@linaro.org, stable@kernel.org, stern@rowland.harvard.edu, tglx@linutronix.de, torvalds@linux-foundation.org, trond.myklebust@hammerspace.com, viresh.kumar@linaro.org, vvs@virtuozzo.com, alex.huangjianhui@huawei.com, dylix.dailei@huawei.com, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration Message-ID: <20190710055628.GB5778@kroah.com> References: <1562728147-30251-1-git-send-email-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562728147-30251-1-git-send-email-nixiaoming@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jul 10, 2019 at 11:09:07AM +0800, Xiaoming Ni wrote: > Registering the same notifier to a hook repeatedly can cause the hook > list to form a ring or lose other members of the list. Then don't do that :) Is there any in-kernel users that do do this? If so, please just fix them. thanks, greg k-h