Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11522456ybi;
        Thu, 25 Jul 2019 18:24:59 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxupNVUqfT03873kSLN/C4Yrr3kPG+DxUfgGQfha9xOjj/mi78S3qrrEnc5OD/Gyyu48FHo
X-Received: by 2002:a17:90a:3651:: with SMTP id s75mr93434625pjb.13.1564104299240;
        Thu, 25 Jul 2019 18:24:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1564104299; cv=none;
        d=google.com; s=arc-20160816;
        b=ina/5bucko5o8PHWg0pO+5UDU7EyhOMD2FLkdwkV2lGdqZsdbYoS+06UTjlE3+Qcq7
         vuW6ZeA+oFalzH0WJvkb0Np9C7oqHf3tZ0o+ILv+sKUtQ+8DMo1jAUWQnhDP5Tyzl44L
         1OjeqkpM2pq6Gt06ZNR0UnOpWIlC19MI3yl3y1hxQ9/ryQv5FmOAKH0YLvNB0qzwGyJ5
         NslpG4hikT0oXLC+Cy/MEkQKTzkdO4hE1alRdc/xN7jQtv0jSkyNvBfIgLYDzQo9X4gn
         XWRNdtU1nI9pm1hRH1DmkRe/+RpEXwMTX5j5LO3JnZDkU0dtswlRwdrjTeo/kTlN3vhF
         8iog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=QKXKINFukbwLIIsnFYM0gxF2tKYcHndEGgwougXKa7I=;
        b=qV1G8gTOmIOKqc62yTqN4CZTPmsDk/I/6E+kMV8LABjJf1VKrTI9R/RGUiBUnyapgO
         ihWTAYNtlmD4DqIdagmXTv+8dgGksMRpBz3Y9gAfK90L9qe7tSYSbMjced0YRRI32Kd4
         EKMgK+02Mo6l7mX0gSjLh9A0Z0hN89lXleOxN2p9qF+N8bFDmZL5XMiv9IfzqA08a8Jf
         6+S242O7M57FbnUG8DQER4Wn/fPv2xeI+H85tZLcs/DoJsUjCielcWB98ihigH2sPpwS
         olE0GrMV6sNHFZZ5CuQ6BSuW4HmT+Jp+93bgSpQ4Z9nXR7essAe4s0GeVC60XTyEJZdr
         zLcA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=PQnzJX5x;
       spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z15si21748004pgf.85.2019.07.25.18.24.34;
        Thu, 25 Jul 2019 18:24:59 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=PQnzJX5x;
       spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725909AbfGZBYT (ORCPT <rfc822;elessard97@gmail.com>
        + 99 others); Thu, 25 Jul 2019 21:24:19 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:12796 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725808AbfGZBYS (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Thu, 25 Jul 2019 21:24:18 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d3a563e0000>; Thu, 25 Jul 2019 18:24:14 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 25 Jul 2019 18:24:17 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 25 Jul 2019 18:24:17 -0700
Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul
 2019 01:24:16 +0000
Subject: Re: [PATCH 00/12] block/bio, fs: convert put_page() to
 put_user_page*()
To:     Bob Liu <bob.liu@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Jason Wang <jasowang@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        Latchesar Ionkov <lucho@ionkov.net>,
        "Michael S . Tsirkin" <mst@redhat.com>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Christoph Hellwig <hch@lst.de>,
        Matthew Wilcox <willy@infradead.org>, <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        <ceph-devel@vger.kernel.org>, <kvm@vger.kernel.org>,
        <linux-block@vger.kernel.org>, <linux-cifs@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
        <samba-technical@lists.samba.org>,
        <v9fs-developer@lists.sourceforge.net>,
        <virtualization@lists.linux-foundation.org>
References: <20190724042518.14363-1-jhubbard@nvidia.com>
 <8621066c-e242-c449-eb04-4f2ce6867140@oracle.com>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <88864b91-516d-9774-f4ca-b45927ac4556@nvidia.com>
Date:   Thu, 25 Jul 2019 18:24:16 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <8621066c-e242-c449-eb04-4f2ce6867140@oracle.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1564104254; bh=QKXKINFukbwLIIsnFYM0gxF2tKYcHndEGgwougXKa7I=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=PQnzJX5xz5ikEiwrLKM8WsALivZ88h6rrpD5As08defMJIkdP+u4c4qNjj9VJ4tt7
         nwv4lirmE3zmhFpqjjtQZ51fomZqIx7+Z5K/hIMgtkne3B/lAraavguLY6SA4HXRUi
         W4SUZZlps8N4rFxPowCNQkldeoVK/fBECjRShYxjtzJx8yvDnyDgvLG3XjCMQgN0HE
         j0RlPZtSamPdX7GpRyHeIVO0klar+OAGzPGoJx+oiz7wZ/GbisDHnJkR/hoyBrvfQa
         +HuyKaWvKrWvHxopvgEQcRa8uv0hWn0N0u4M8vDDfrnuUHyPlJZxMytFt1GB3uPYBU
         1cdZ+M2GXGeqw==
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 7/24/19 5:41 PM, Bob Liu wrote:
> On 7/24/19 12:25 PM, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> Hi,
>>
>> This is mostly Jerome's work, converting the block/bio and related areas
>> to call put_user_page*() instead of put_page(). Because I've changed
>> Jerome's patches, in some cases significantly, I'd like to get his
>> feedback before we actually leave him listed as the author (he might
>> want to disown some or all of these).
>>
> 
> Could you add some background to the commit log for people don't have the context..
> Why this converting? What's the main differences?
> 

Hi Bob,

1. Many of the patches have a blurb like this:

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

...and if you look at that commit, you'll find several pages of
information in its commit description, which should address your point.

2. This whole series has to be re-worked, as per the other feedback thread.
So I'll keep your comment in mind when I post a new series.

thanks,
-- 
John Hubbard
NVIDIA