Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3273824ybl; Mon, 19 Aug 2019 15:37:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0gx4yIsDZcTYsKxsccMXaO1HOlw5zwvKAe9hSkTCMdG/zdO8jrC6AM4B3zKSQ/oMryvvd X-Received: by 2002:a17:902:7441:: with SMTP id e1mr24825063plt.37.1566254279538; Mon, 19 Aug 2019 15:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566254279; cv=none; d=google.com; s=arc-20160816; b=KVffdxoWUAKyxQHxVrTNTA1E/pG4ynmduFOE8jHkejge3HEzyaHH379mNqhVnZY6ru Eyt1LtaLPY6m8D21lzxih+7An4OzxPQj2TW2yFM2YocAKm3RaYIVKCLmNFPtIggmOv9z dLYyEgI6Fd62oNtuyohZSmesTrDtjtuSWICjx3/K9YsoMHA6FktKSTbYRw+RBLyOvssl 3Z7Xv2ArjUYuR7wucHbp+lXUqL8rmyb23hqvz32Jj/sxRGQfEDDxAm5krY9JvE2qli8M 9SvRBfTRpeBV+4G//PES9N8jlY8ozvR4VDJCdlLcblt3K6YxTPIlm6/HtTVKAIB4Vch6 Iuaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=KGw+O8zhRdR6qOzf1+hFXDgB8d55DXqyorgudiaLglA=; b=p+6Dc44dUG/FSiEpNJwaouvG4yz0MFwnDXjIoBdB2T6bpNOjyjm3kJQilsQosIeP5C LuUEZZPBBKtUL92Sbf3V+juD8sRB8SufwqMtc9xXy7L9piowt051d1ZUN/p5tVXMbIW5 YORWz45BwChUC6H5DFPwzAYe2BoiAM6McEeR24FCAnWX1hNZavThk3Ap/jb7m/AUw/Yk mW5WI997RWES/YR8NSdIkrQoCPpR41ehLlrSrwTFDtuGLxdioBpr+hGz/5G1fWKA4HDy DiKLtmNXRupHzRH1Klskl3otUTKY1Rj4J8Pxj+5JtHmmOEtr1O+6yaySK2JSk7AJVIso oiJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Sn4TwetY; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d3si11530863pfq.7.2019.08.19.15.37.45; Mon, 19 Aug 2019 15:37:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Sn4TwetY; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbfHSWh2 (ORCPT + 99 others); Mon, 19 Aug 2019 18:37:28 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:45136 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728494AbfHSWh2 (ORCPT ); Mon, 19 Aug 2019 18:37:28 -0400 Received: by mail-oi1-f196.google.com with SMTP id v12so2587191oic.12; Mon, 19 Aug 2019 15:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=KGw+O8zhRdR6qOzf1+hFXDgB8d55DXqyorgudiaLglA=; b=Sn4TwetYV1xBZAep9BXXAFmwF7kGpp8l16LWM65wutSt1AceQdBSJmwzayzUwQ6vay Qvji3v0RFTt9PHNniGiETy7AsVGMHXa3mqnoWFsPGiqcL1aORVPMrGHo1Bd+j7Eb87aR 7LMfud0rJ66jp1xdKoj5rvQZUmqzqJcxz09csJO6vTT8pB069BjgwfAXMb5MChRg+5u/ rbkYatrun4C+8kKRlNE5zkDldDiDWUw/Ncte8jz5eRDhI3XuWn/hdIIoXnG7qF9KBFoE h4zbYVQcupqLiHkN97vWg/QUga63q9a4/i5Z43OZih1iQz9WZ2PVnAh3PK+p7MjQKAG2 TVtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=KGw+O8zhRdR6qOzf1+hFXDgB8d55DXqyorgudiaLglA=; b=JxzcF5h50vWurRtJY/coxqqZOuYkWl4Nt4HSzR5XGiHHDWAVI0yredWHwyHrGeYOsL mo8Q1qS6Dhwsp9u17TgldBz4aT4yAAsn10QnmMuk0FPdLo8CiCe7xH++L9ijvGAB0/nu AUOSrac1v6FMnM9LUYYcnOR4dDWOZuz0e5mzoOAx8TDcDtyE7uns+50mT3BC1TGiCV6p q5QAWWX4bX3QUrUGVlAUPtvUI2AkM3SWlTAWOI0yP2NNQnhVZLRZ63j91QZsbAbpUft6 YF5dgmlA99Yrc1oEYBwirw1gftLWEVW36vjuU12vkM0vS0PIfgmTjUR+VPm6l7P3HcIQ O3Mg== X-Gm-Message-State: APjAAAWoXZAomIl9aYpT0Oue8KU20coS+V7nGQoVm9oNA/MUr/Ceg+8t 2dXaGFzMgYszz0JQe5IMcQFfDX3G X-Received: by 2002:aca:3804:: with SMTP id f4mr14365915oia.144.1566254246924; Mon, 19 Aug 2019 15:37:26 -0700 (PDT) Received: from seurat29.1015granger.net ([12.235.16.3]) by smtp.gmail.com with ESMTPSA id 23sm1541199oiz.8.2019.08.19.15.37.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 15:37:26 -0700 (PDT) Subject: [PATCH v2 02/21] SUNRPC: Inline xdr_commit_encode From: Chuck Lever To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Date: Mon, 19 Aug 2019 18:37:05 -0400 Message-ID: <156625420544.8161.7549333388864452214.stgit@seurat29.1015granger.net> In-Reply-To: <156625401091.8161.14744201497689200191.stgit@seurat29.1015granger.net> References: <156625401091.8161.14744201497689200191.stgit@seurat29.1015granger.net> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Micro-optimization: For xdr_commit_encode call sites in net/sunrpc/xdr.c, eliminate the extra calling sequence. On my client, this change saves about a microsecond for every 30 calls to xdr_reserve_space(). Signed-off-by: Chuck Lever --- net/sunrpc/xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index 48c93b9e525e..7ba0ede6b417 100644 --- a/net/sunrpc/xdr.c +++ b/net/sunrpc/xdr.c @@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(xdr_init_encode); * required at the end of encoding, or any other time when the xdr_buf * data might be read. */ -void xdr_commit_encode(struct xdr_stream *xdr) +inline void xdr_commit_encode(struct xdr_stream *xdr) { int shift = xdr->scratch.iov_len; void *page;