Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2205674ybe; Thu, 12 Sep 2019 06:13:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSe4qW5MnVXhlIxh462dnRzSpbKjYf5sdyZ4EER9Mk6oonSeFpJrofd1lvcFoYgOOoUZql X-Received: by 2002:aa7:c6ca:: with SMTP id b10mr41799123eds.233.1568293995727; Thu, 12 Sep 2019 06:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568293995; cv=none; d=google.com; s=arc-20160816; b=L9oLGt51Qw6NDJBjI+p7udzwU31+wZgeItnkBdrnkABJIasKE7nJVo0Tc4L9c/fncO Ri5WXPZjJFMii9Wd54oHgh3Ko0VwA2q/EamYF9ywCo4DbmnLRJa68Fnr4CLbVkHsVMNy pyQQrEJUTlbwVsi2N0Kr1MVYdXA4JkBwxN45eBs9uwRaXqPHwDBHSZU57TGC7cR4a6KZ ui3vcMDKJQiXxmKrFTQyRlbgsTrrTGxM2Ok8DmY2RQxxlbGVy4k5i9i+V1BIbtbLIbh5 cI2BG7Lp6BhtFMjXgk0XH418J4yVkv3ryzDl8oiL3e5LT40W46jxS2MYqEdzyterusur ocbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=JKShEOIvnGYrQTdy5aAte7sKNSja26WdYzArqq1vb6U=; b=LnbxxL9Q3eO4kzEi6DL5Vr05ZK0+06EtWqc0L4aYoHMiEQHs2N7rUTt+EfkG+ORGCz jE3ar5buCU2cuNTiwjvv+D3eHVMbr32uje/+4HSwJpvbDEO7ceJGRU0mT7VzCe5fZtkj BqRTkvCAxS6n+QNCT9oS1kFt4gBe2lxd0G+DThVElZqdGmd9PXlJyuGlJ+t4yCRBchqa Gom/fMwan6V7uRFVv85okoU0qeW0HTE4aEh9Wy9cnosRrZ+jTfIH4eDgpRhE1o1C07j+ vKuTyn4K6sOSBsy8VZBvkcFF3vnxLiWASBrH7Hp959ynixXRftQS+3beMmmd5YoSN/cW ghHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si2561973ejj.369.2019.09.12.06.12.44; Thu, 12 Sep 2019 06:13:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731749AbfILNIy (ORCPT + 99 others); Thu, 12 Sep 2019 09:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58168 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbfILNIx (ORCPT ); Thu, 12 Sep 2019 09:08:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B4CF8BA2DA; Thu, 12 Sep 2019 13:08:53 +0000 (UTC) Received: from [172.16.176.1] (ovpn-64-2.rdu2.redhat.com [10.10.64.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AE02600C4; Thu, 12 Sep 2019 13:08:52 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" Cc: chuck.lever@oracle.com, tibbs@math.uh.edu, bfields@fieldses.org, linux@stwm.de, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, km@cm4all.com Subject: Re: Regression in 5.1.20: Reading long directory fails Date: Thu, 12 Sep 2019 09:08:51 -0400 Message-ID: <57185A91-0AC8-4805-B6CE-67D629F814C2@redhat.com> In-Reply-To: References: <4418877.15LTP4gqqJ@stwm.de> <4198657.JbNDGbLXiX@h2o.as.studentenwerk.mhn.de> <20190906144837.GD17204@fieldses.org> <75F810C6-E99E-40C3-B5E1-34BA2CC42773@oracle.com> <0089DF80-3A1C-4F0B-A200-28FF7CFD0C65@oracle.com> <429B2B1F-FB55-46C5-8BC5-7644CE9A5894@redhat.com> <8D7EFCEB-4AE6-4963-B66F-4A8EEA5EA42A@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 12 Sep 2019 13:08:53 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 12 Sep 2019, at 8:53, Trond Myklebust wrote: > Let's please just scrap this function and rewrite it as a generic > function for reading the MIC. It clearly is not a generic function for > reading arbitrary netobjs, and modifications like the above just make > the misnomer painfully obvious. > > Let's rewrite it as xdr_buf_read_mic() so that we can simplify it where > possible. Ok. I want to assume the mic will not land in the head, but I am not sure.. Is there a scenario where the mic might land in the head, or is that bit of the current function left over from other uses? Ben