Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        "J. Bruce Fields" <bfields@redhat.com>
Cc:     linux-nfs@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>
From:   Randy Dunlap <rdunlap@infradead.org>
Subject: fs/nfsd/nfs4state.c use of "\%s"
Message-ID: <b76bde04-7970-c870-5af7-359141958c4f@infradead.org>
Date:   Wed, 2 Oct 2019 17:17:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi Bruce,

In commit 78599c42ae3c70300a38b0d1271a85bc9f2d704a
(nfsd4: add file to display list of client's opens), some of the %s printk
specifiers are \-escaped:

+       seq_printf(s, "access: \%s\%s, ",
+               access & NFS4_SHARE_ACCESS_READ ? "r" : "-",
+               access & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");
+       seq_printf(s, "deny: \%s\%s, ",
+               deny & NFS4_SHARE_ACCESS_READ ? "r" : "-",
+               deny & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");


sparse complains about these, as does gcc when used with --pedantic.
sparse says:

../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'
../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'

Is this just a typo?

Please just fix it.

thanks,
-- 
~Randy