Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 3 Oct 2019 12:42:17 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        "J. Bruce Fields" <bfields@redhat.com>, linux-nfs@vger.kernel.org,
        Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: fs/nfsd/nfs4state.c use of "\%s"
Message-ID: <20191003164217.GA25406@fieldses.org>
References: <b76bde04-7970-c870-5af7-359141958c4f@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b76bde04-7970-c870-5af7-359141958c4f@infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 02, 2019 at 05:17:27PM -0700, Randy Dunlap wrote:
> Hi Bruce,
> 
> In commit 78599c42ae3c70300a38b0d1271a85bc9f2d704a
> (nfsd4: add file to display list of client's opens), some of the %s printk
> specifiers are \-escaped:
> 
> +       seq_printf(s, "access: \%s\%s, ",
> +               access & NFS4_SHARE_ACCESS_READ ? "r" : "-",
> +               access & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");
> +       seq_printf(s, "deny: \%s\%s, ",
> +               deny & NFS4_SHARE_ACCESS_READ ? "r" : "-",
> +               deny & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");
> 
> 
> sparse complains about these, as does gcc when used with --pedantic.
> sparse says:
> 
> ../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'
> 
> Is this just a typo?

Yes, weird, I wonder how that crept in.

Patch queued up for 5.5, thanks.

--b.