Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 11 Oct 2019 12:49:28 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1] nfsd: remove private bin2hex implementation
Message-ID: <20191011164928.GC19318@fieldses.org>
References: <20191011160258.8562-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191011160258.8562-1-andriy.shevchenko@linux.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Thanks, applying.--b.

On Fri, Oct 11, 2019 at 07:02:58PM +0300, Andy Shevchenko wrote:
> Calling sprintf in a loop is not very efficient, and in any case,
> we already have an implementation of bin-to-hex conversion in lib/
> which we might as well use.
> 
> Note that original code used to nul-terminate the destination while
> bin2hex doesn't. That's why replace kmalloc() with kzalloc().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  fs/nfsd/nfs4recover.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index cdc75ad4438b..29dff4c6e752 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -1850,19 +1850,14 @@ nfsd4_umh_cltrack_upcall(char *cmd, char *arg, char *env0, char *env1)
>  static char *
>  bin_to_hex_dup(const unsigned char *src, int srclen)
>  {
> -	int i;
> -	char *buf, *hex;
> +	char *buf;
>  
>  	/* +1 for terminating NULL */
> -	buf = kmalloc((srclen * 2) + 1, GFP_KERNEL);
> +	buf = kzalloc((srclen * 2) + 1, GFP_KERNEL);
>  	if (!buf)
>  		return buf;
>  
> -	hex = buf;
> -	for (i = 0; i < srclen; i++) {
> -		sprintf(hex, "%2.2x", *src++);
> -		hex += 2;
> -	}
> +	bin2hex(buf, src, srclen);
>  	return buf;
>  }
>  
> -- 
> 2.23.0