Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] nfsd: v4 support requires CRYPTO_SHA256
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20191112190155.12872-1-smayhew@redhat.com>
Date:   Tue, 12 Nov 2019 14:07:49 -0500
Cc:     Bruce Fields <bfields@fieldses.org>, jamie@audible.transient.net,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: 7bit
Message-Id: <81E4B70E-CD38-4B89-AE0C-3AFFCACB0A42@oracle.com>
References: <20191112190155.12872-1-smayhew@redhat.com>
To:     Scott Mayhew <smayhew@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Nov 12, 2019, at 2:01 PM, Scott Mayhew <smayhew@redhat.com> wrote:
> 
> The new nfsdcld client tracking operations use sha256 to compute hashes
> of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
> 
> Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>

I recently noticed this too in passing. I didn't have a chance to
give a thought about exactly how to address it, but this looks OK
to me.


> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 10cefb0c07c7..c4b1a89b8845 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -73,7 +73,7 @@ config NFSD_V4
> 	select NFSD_V3
> 	select FS_POSIX_ACL
> 	select SUNRPC_GSS
> -	select CRYPTO
> +	select CRYPTO_SHA256
> 	select GRACE_PERIOD
> 	help
> 	  This option enables support in your system's NFS server for
> -- 
> 2.17.2
> 

--
Chuck Lever