Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
To:     linux-nfs@vger.kernel.org, Steve Dickson <steved@redhat.com>
From:   Doug Nazar <nazard@nazar.ca>
Subject: Re: ANNOUNCE: nfs-utils-2.4.2 released.
Message-ID: <04f375d6-e50a-0b5e-7095-dbc3907bfe23@nazar.ca>
Date:   Sun, 17 Nov 2019 12:47:23 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101
 Thunderbird/71.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------90FC4A4BA1A4B9680F3CEFC5"
Content-Language: en-US
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

This is a multi-part message in MIME format.
--------------90FC4A4BA1A4B9680F3CEFC5
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

This still causes crashes in mountd on 32bit systems without 
https://marc.info/?l=linux-nfs&m=157250894818731&w=2

mountd: Version 2.4.2 starting
mountd: auth_unix_ip: inbuf 'nfsd fde2:2b6c:2d24:0021:0000:0000:0000:0050'
mountd: auth_unix_ip: client 0x13cd900 '*'
mountd: nfsd_fh: inbuf '* 6 \xd1fb45ab77b345d99b09b3217dcdf2ec'
*** stack smashing detected ***: <unknown> terminated
Aborted

Call chain looks like:

get_rootfh                    utils/mountd/mountd.c
     check_is_mountpoint       support/misc/mountpoint.c
         nfsd_path_lstat       support/misc/nfsd_path.c    *
             xlstat            support/misc/xstat.c        *

where two struct stats are declared on the stack in mountpoint.c without 
including config.h and getting the __USE_FILE_OFFSET64 define, however 
the following two files in the call chain include config.h and get a 
different size struct stat.

Also attached are a few printf formating fixes for 32 bit.

Doug


--------------90FC4A4BA1A4B9680F3CEFC5
Content-Type: text/plain; charset=UTF-8;
 name="0001-nfsdcld-Fix-printf-format-strings-on-32bit.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-nfsdcld-Fix-printf-format-strings-on-32bit.patch"

RnJvbSBjMzZjZTFhMmE1ZGYwYmI2YTUwMTM5YzFhZTI0NmM0YmFiNmU5MTg0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEb3VnIE5hemFyIDxuYXphcmRAbmF6YXIuY2E+CkRh
dGU6IFN1biwgMTcgTm92IDIwMTkgMTI6NDI6MjEgLTA1MDAKU3ViamVjdDogW1BBVENIXSBu
ZnNkY2xkOiBGaXggcHJpbnRmIGZvcm1hdCBzdHJpbmdzIG9uIDMyYml0CgpTaWduZWQtb2Zm
LWJ5OiBEb3VnIE5hemFyIDxuYXphcmRAbmF6YXIuY2E+Ci0tLQogdXRpbHMvbmZzZGNsZC9u
ZnNkY2xkLmMgfCAxNCArKysrKysrLS0tLS0tLQogdXRpbHMvbmZzZGNsZC9zcWxpdGUuYyAg
fCAgNiArKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdXRpbHMvbmZzZGNsZC9uZnNkY2xkLmMgYi91dGls
cy9uZnNkY2xkL25mc2RjbGQuYwppbmRleCBiMDY0MzM2ZC4uOTI5N2RmNTEgMTAwNjQ0Ci0t
LSBhL3V0aWxzL25mc2RjbGQvbmZzZGNsZC5jCisrKyBiL3V0aWxzL25mc2RjbGQvbmZzZGNs
ZC5jCkBAIC0zNzgsNyArMzc4LDcgQEAgY2xkX25vdF9pbXBsZW1lbnRlZChzdHJ1Y3QgY2xk
X2NsaWVudCAqY2xudCkKIAlic2l6ZSA9IGNsZF9tZXNzYWdlX3NpemUoY21zZyk7CiAJd3Np
emUgPSBhdG9taWNpbygodm9pZCAqKXdyaXRlLCBjbG50LT5jbF9mZCwgY21zZywgYnNpemUp
OwogCWlmICh3c2l6ZSAhPSBic2l6ZSkKLQkJeGxvZyhMX0VSUk9SLCAiJXM6IHByb2JsZW0g
d3JpdGluZyB0byBjbGQgcGlwZSAoJWxkKTogJW0iLAorCQl4bG9nKExfRVJST1IsICIlczog
cHJvYmxlbSB3cml0aW5nIHRvIGNsZCBwaXBlICglemQpOiAlbSIsCiAJCQkgX19mdW5jX18s
IHdzaXplKTsKIAogCS8qIHJlb3BlbiBwaXBlLCBqdXN0IHRvIGJlIHN1cmUgKi8KQEAgLTQw
OSw3ICs0MDksNyBAQCBjbGRfZ2V0X3ZlcnNpb24oc3RydWN0IGNsZF9jbGllbnQgKmNsbnQp
CiAJeGxvZyhEX0dFTkVSQUwsICJEb2luZyBkb3duY2FsbCB3aXRoIHN0YXR1cyAlZCIsIGNt
c2ctPmNtX3N0YXR1cyk7CiAJd3NpemUgPSBhdG9taWNpbygodm9pZCAqKXdyaXRlLCBjbG50
LT5jbF9mZCwgY21zZywgYnNpemUpOwogCWlmICh3c2l6ZSAhPSBic2l6ZSkgewotCQl4bG9n
KExfRVJST1IsICIlczogcHJvYmxlbSB3cml0aW5nIHRvIGNsZCBwaXBlICglbGQpOiAlbSIs
CisJCXhsb2coTF9FUlJPUiwgIiVzOiBwcm9ibGVtIHdyaXRpbmcgdG8gY2xkIHBpcGUgKCV6
ZCk6ICVtIiwKIAkJCSBfX2Z1bmNfXywgd3NpemUpOwogCQlyZXQgPSBjbGRfcGlwZV9vcGVu
KGNsbnQpOwogCQlpZiAocmV0KSB7CkBAIC00NTksNyArNDU5LDcgQEAgcmVwbHk6CiAJeGxv
ZyhEX0dFTkVSQUwsICJEb2luZyBkb3duY2FsbCB3aXRoIHN0YXR1cyAlZCIsIGNtc2ctPmNt
X3N0YXR1cyk7CiAJd3NpemUgPSBhdG9taWNpbygodm9pZCAqKXdyaXRlLCBjbG50LT5jbF9m
ZCwgY21zZywgYnNpemUpOwogCWlmICh3c2l6ZSAhPSBic2l6ZSkgewotCQl4bG9nKExfRVJS
T1IsICIlczogcHJvYmxlbSB3cml0aW5nIHRvIGNsZCBwaXBlICglbGQpOiAlbSIsCisJCXhs
b2coTF9FUlJPUiwgIiVzOiBwcm9ibGVtIHdyaXRpbmcgdG8gY2xkIHBpcGUgKCV6ZCk6ICVt
IiwKIAkJCSBfX2Z1bmNfXywgd3NpemUpOwogCQlyZXQgPSBjbGRfcGlwZV9vcGVuKGNsbnQp
OwogCQlpZiAocmV0KSB7CkBAIC00OTgsNyArNDk4LDcgQEAgcmVwbHk6CiAJCQljbXNnLT5j
bV9zdGF0dXMpOwogCXdzaXplID0gYXRvbWljaW8oKHZvaWQgKil3cml0ZSwgY2xudC0+Y2xf
ZmQsIGNtc2csIGJzaXplKTsKIAlpZiAod3NpemUgIT0gYnNpemUpIHsKLQkJeGxvZyhMX0VS
Uk9SLCAiJXM6IHByb2JsZW0gd3JpdGluZyB0byBjbGQgcGlwZSAoJWxkKTogJW0iLAorCQl4
bG9nKExfRVJST1IsICIlczogcHJvYmxlbSB3cml0aW5nIHRvIGNsZCBwaXBlICglemQpOiAl
bSIsCiAJCQkgX19mdW5jX18sIHdzaXplKTsKIAkJcmV0ID0gY2xkX3BpcGVfb3BlbihjbG50
KTsKIAkJaWYgKHJldCkgewpAQCAtNTQ4LDcgKzU0OCw3IEBAIHJlcGx5OgogCQkJY21zZy0+
Y21fc3RhdHVzKTsKIAl3c2l6ZSA9IGF0b21pY2lvKCh2b2lkICopd3JpdGUsIGNsbnQtPmNs
X2ZkLCBjbXNnLCBic2l6ZSk7CiAJaWYgKHdzaXplICE9IGJzaXplKSB7Ci0JCXhsb2coTF9F
UlJPUiwgIiVzOiBwcm9ibGVtIHdyaXRpbmcgdG8gY2xkIHBpcGUgKCVsZCk6ICVtIiwKKwkJ
eGxvZyhMX0VSUk9SLCAiJXM6IHByb2JsZW0gd3JpdGluZyB0byBjbGQgcGlwZSAoJXpkKTog
JW0iLAogCQkJIF9fZnVuY19fLCB3c2l6ZSk7CiAJCXJldCA9IGNsZF9waXBlX29wZW4oY2xu
dCk7CiAJCWlmIChyZXQpIHsKQEAgLTYwNyw3ICs2MDcsNyBAQCByZXBseToKIAl4bG9nKERf
R0VORVJBTCwgIkRvaW5nIGRvd25jYWxsIHdpdGggc3RhdHVzICVkIiwgY21zZy0+Y21fc3Rh
dHVzKTsKIAl3c2l6ZSA9IGF0b21pY2lvKCh2b2lkICopd3JpdGUsIGNsbnQtPmNsX2ZkLCBj
bXNnLCBic2l6ZSk7CiAJaWYgKHdzaXplICE9IGJzaXplKSB7Ci0JCXhsb2coTF9FUlJPUiwg
IiVzOiBwcm9ibGVtIHdyaXRpbmcgdG8gY2xkIHBpcGUgKCVsZCk6ICVtIiwKKwkJeGxvZyhM
X0VSUk9SLCAiJXM6IHByb2JsZW0gd3JpdGluZyB0byBjbGQgcGlwZSAoJXpkKTogJW0iLAog
CQkJIF9fZnVuY19fLCB3c2l6ZSk7CiAJCXJldCA9IGNsZF9waXBlX29wZW4oY2xudCk7CiAJ
CWlmIChyZXQpIHsKQEAgLTY2Nyw3ICs2NjcsNyBAQCByZXBseToKIAl4bG9nKERfR0VORVJB
TCwgIkRvaW5nIGRvd25jYWxsIHdpdGggc3RhdHVzICVkIiwgY21zZy0+Y21fc3RhdHVzKTsK
IAl3c2l6ZSA9IGF0b21pY2lvKCh2b2lkICopd3JpdGUsIGNsbnQtPmNsX2ZkLCBjbXNnLCBi
c2l6ZSk7CiAJaWYgKHdzaXplICE9IGJzaXplKSB7Ci0JCXhsb2coTF9FUlJPUiwgIiVzOiBw
cm9ibGVtIHdyaXRpbmcgdG8gY2xkIHBpcGUgKCVsZCk6ICVtIiwKKwkJeGxvZyhMX0VSUk9S
LCAiJXM6IHByb2JsZW0gd3JpdGluZyB0byBjbGQgcGlwZSAoJXpkKTogJW0iLAogCQkJIF9f
ZnVuY19fLCB3c2l6ZSk7CiAJCXJldCA9IGNsZF9waXBlX29wZW4oY2xudCk7CiAJCWlmIChy
ZXQpIHsKZGlmZiAtLWdpdCBhL3V0aWxzL25mc2RjbGQvc3FsaXRlLmMgYi91dGlscy9uZnNk
Y2xkL3NxbGl0ZS5jCmluZGV4IDIzYmU3OTcxLi4wOTUxOGUyMiAxMDA2NDQKLS0tIGEvdXRp
bHMvbmZzZGNsZC9zcWxpdGUuYworKysgYi91dGlscy9uZnNkY2xkL3NxbGl0ZS5jCkBAIC01
MTIsNyArNTEyLDcgQEAgc3FsaXRlX3N0YXJ0dXBfcXVlcnlfZ3JhY2Uodm9pZCkKIAljdXJy
ZW50X2Vwb2NoID0gdGN1cjsKIAlyZWNvdmVyeV9lcG9jaCA9IHRyZWM7CiAJcmV0ID0gMDsK
LQl4bG9nKERfR0VORVJBTCwgIiVzOiBjdXJyZW50X2Vwb2NoPSVsdSByZWNvdmVyeV9lcG9j
aD0lbHUiLAorCXhsb2coRF9HRU5FUkFMLCAiJXM6IGN1cnJlbnRfZXBvY2g9JSJQUkl1NjQi
IHJlY292ZXJ5X2Vwb2NoPSUiUFJJdTY0LAogCQlfX2Z1bmNfXywgY3VycmVudF9lcG9jaCwg
cmVjb3ZlcnlfZXBvY2gpOwogb3V0OgogCXNxbGl0ZTNfZmluYWxpemUoc3RtdCk7CkBAIC0x
MjIzLDcgKzEyMjMsNyBAQCBzcWxpdGVfZ3JhY2Vfc3RhcnQodm9pZCkKIAogCWN1cnJlbnRf
ZXBvY2ggPSB0Y3VyOwogCXJlY292ZXJ5X2Vwb2NoID0gdHJlYzsKLQl4bG9nKERfR0VORVJB
TCwgIiVzOiBjdXJyZW50X2Vwb2NoPSVsdSByZWNvdmVyeV9lcG9jaD0lbHUiLAorCXhsb2co
RF9HRU5FUkFMLCAiJXM6IGN1cnJlbnRfZXBvY2g9JSJQUkl1NjQiIHJlY292ZXJ5X2Vwb2No
PSUiUFJJdTY0LAogCQlfX2Z1bmNfXywgY3VycmVudF9lcG9jaCwgcmVjb3ZlcnlfZXBvY2gp
OwogCiBvdXQ6CkBAIC0xMjgyLDcgKzEyODIsNyBAQCBzcWxpdGVfZ3JhY2VfZG9uZSh2b2lk
KQogCX0KIAogCXJlY292ZXJ5X2Vwb2NoID0gMDsKLQl4bG9nKERfR0VORVJBTCwgIiVzOiBj
dXJyZW50X2Vwb2NoPSVsdSByZWNvdmVyeV9lcG9jaD0lbHUiLAorCXhsb2coRF9HRU5FUkFM
LCAiJXM6IGN1cnJlbnRfZXBvY2g9JSJQUkl1NjQiIHJlY292ZXJ5X2Vwb2NoPSUiUFJJdTY0
LAogCQlfX2Z1bmNfXywgY3VycmVudF9lcG9jaCwgcmVjb3ZlcnlfZXBvY2gpOwogCiBvdXQ6
Ci0tIAoyLjIzLjAKCg==
--------------90FC4A4BA1A4B9680F3CEFC5--