Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Ensure consistent struct stat definition
To:     Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
References: <20191031070355.26471-1-nazard@nazar.ca>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <fb4ee698-164c-df5c-5efe-fe59de1a0177@RedHat.com>
Date:   Sun, 17 Nov 2019 14:33:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191031070355.26471-1-nazard@nazar.ca>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 10/31/19 3:03 AM, Doug Nazar wrote:
> Although 2fbc62e2a13fc ("Fix include order between config.h and stat.h")
> reorganized those files that were already including config.h, not all
> files were including config.h.
>=20
> Fixes at least stack smashing crashes in mountd on 32-bit systems.
>=20
> Signed-off-by: Doug Nazar <nazard@nazar.ca>
> ---
>  support/junction/junction.c | 4 ++++
>  support/misc/file.c         | 4 ++++
>  support/misc/mountpoint.c   | 4 ++++
>  support/nfs/cacheio.c       | 4 ++++
>  utils/mount/fstab.c         | 4 ++++
>  utils/nfsdcld/legacy.c      | 4 ++++
>  6 files changed, 24 insertions(+)
Committed!=20

steved.
>=20
> diff --git a/support/junction/junction.c b/support/junction/junction.c
> index ab6caa61..41cce261 100644
> --- a/support/junction/junction.c
> +++ b/support/junction/junction.c
> @@ -23,6 +23,10 @@
>   *=09http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <sys/types.h>
>  #include <sys/stat.h>
> =20
> diff --git a/support/misc/file.c b/support/misc/file.c
> index e7c38190..06f6bb2b 100644
> --- a/support/misc/file.c
> +++ b/support/misc/file.c
> @@ -18,6 +18,10 @@
>   * along with nfs-utils.  If not, see <http://www.gnu.org/licenses/>.
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <sys/stat.h>
> =20
>  #include <string.h>
> diff --git a/support/misc/mountpoint.c b/support/misc/mountpoint.c
> index c6217f24..14d6731d 100644
> --- a/support/misc/mountpoint.c
> +++ b/support/misc/mountpoint.c
> @@ -3,6 +3,10 @@
>   * check if a given path is a mountpoint=20
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <string.h>
>  #include "xcommon.h"
>  #include <sys/stat.h>
> diff --git a/support/nfs/cacheio.c b/support/nfs/cacheio.c
> index 9dc4cf1c..7c4cf373 100644
> --- a/support/nfs/cacheio.c
> +++ b/support/nfs/cacheio.c
> @@ -15,6 +15,10 @@
>   *
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <nfslib.h>
>  #include <stdio.h>
>  #include <stdio_ext.h>
> diff --git a/utils/mount/fstab.c b/utils/mount/fstab.c
> index eedbddab..8b0aaf1a 100644
> --- a/utils/mount/fstab.c
> +++ b/utils/mount/fstab.c
> @@ -7,6 +7,10 @@
>   * - Moved code to nfs-utils/support/nfs from util-linux/mount.
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <errno.h>
>  #include <stdio.h>
>  #include <fcntl.h>
> diff --git a/utils/nfsdcld/legacy.c b/utils/nfsdcld/legacy.c
> index 07f477ab..3c6bea6c 100644
> --- a/utils/nfsdcld/legacy.c
> +++ b/utils/nfsdcld/legacy.c
> @@ -15,6 +15,10 @@
>   * Boston, MA 02110-1301, USA.
>   */
> =20
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
>  #include <stdio.h>
>  #include <dirent.h>
>  #include <string.h>
>=20