Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: ANNOUNCE: nfs-utils-2.4.2 released.
To:     Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
References: <04f375d6-e50a-0b5e-7095-dbc3907bfe23@nazar.ca>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <fd6a75d4-9b52-9c8f-9ad5-d01340fdb89e@RedHat.com>
Date:   Sun, 17 Nov 2019 14:40:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <04f375d6-e50a-0b5e-7095-dbc3907bfe23@nazar.ca>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hey,

On 11/17/19 12:47 PM, Doug Nazar wrote:
> This still causes crashes in mountd on 32bit systems without https://marc=
.info/?l=3Dlinux-nfs&m=3D157250894818731&w=3D2
>=20
> mountd: Version 2.4.2 starting
> mountd: auth_unix_ip: inbuf 'nfsd fde2:2b6c:2d24:0021:0000:0000:0000:0050=
'
> mountd: auth_unix_ip: client 0x13cd900 '*'
> mountd: nfsd_fh: inbuf '* 6 \xd1fb45ab77b345d99b09b3217dcdf2ec'
> *** stack smashing detected ***: <unknown> terminated
> Aborted
>=20
> Call chain looks like:
>=20
> get_rootfh=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=
=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 utils/mountd/mountd.c
> =C2=A0=C2=A0=C2=A0 check_is_mountpoint=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 sup=
port/misc/mountpoint.c
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 nfsd_path_lstat=C2=A0=C2=A0 =C2=A0=
=C2=A0=C2=A0 support/misc/nfsd_path.c=C2=A0=C2=A0=C2=A0 *
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 xlstat=C2=A0=C2=
=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 support/misc/xstat.c=C2=A0=
=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 *
>=20
> where two struct stats are declared on the stack in mountpoint.c without =
including config.h and getting the __USE_FILE_OFFSET64 define, however the =
following two files in the call chain include config.h and get a different =
size struct stat.
>=20
> Also attached are a few printf formating fixes for 32 bit.
My apologies... I did miss this patch in the last release, but the
patch is now committed...=20

I blame the American Halloween... the day the patch was posted! :-)=20
Those darn spooks and goblins of getting in the way!! 8-)=20

steved.