Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2112546ybc; Sun, 17 Nov 2019 14:20:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxTt6ev7rZFpdXSuvPtzM1dMu0rinFRTASjBYhR5bsgZAX1vJOHrzv0eE2BeNBdQ943lojI X-Received: by 2002:a17:906:4d58:: with SMTP id b24mr21293635ejv.277.1574029229899; Sun, 17 Nov 2019 14:20:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574029229; cv=none; d=google.com; s=arc-20160816; b=A1i8fr2lOPotqVm2zNOFxat/SB1aPRCXs+DbAgfGPvcOyDD6tN0N9MCskU7Iqs7zg6 uTxaNZkc9g00gFwqDdkqOecVE9shViAbhexidY2fCMZnaqWJzxrZwZGHmUtp2BFtKCAE vsCw9THVO3MXwGQfQe2DAuCsOYdOVrErMt9oPtOyasVGiDNf5bviFcrYYLmOC38lRmpn C/luSJvGeuoVRTfU/7IphzO2cjia8kfXunvjxXwByOrIJdK+k0s5rd52laFku4ChlTkw Lezir+Jaw+1CdKKCUOoKB/WcYHkrruRh0/NgW85kGZUJoYcdF34BPeZROis1Sd+1kF17 fOLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uerFL31jjYFZFwF2Yn4Ol5lMqXHtUOh4W1BX0+Oh8Xo=; b=B04VpawhKjRtrlZ4JCIE9MHn8n9JxSDLC91b5+gUEePdj756ItWAap3cCmmYqi9Nts 9qrsHvBoaG5DTCDSjP1NCbQ2ru0NIvIquKaBgJmxu9w9D+7U9FDteHEvzqi7GaEkoUyY FUqv/0ykRP5tyLZGIb0PuzLTIwCa4QG6GVBreNNH/EJ7yVnmmT+7eVacOmOboSaktH3o 5ZKsvwzQGu3ZokxvWsGHSepIHGupVvpfAqBHF9IGbqnV/APJZDU03v45GvhybjYunxh2 tKA34yW5Zaz0O8j/KTHML6POZS1L7g9GkTH8TI2V+X/uTLoGHl2xrCszq7CjbNBTk7ox iXcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RlIOTDji; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x70si12395343ede.257.2019.11.17.14.19.53; Sun, 17 Nov 2019 14:20:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RlIOTDji; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbfKQWPW (ORCPT + 99 others); Sun, 17 Nov 2019 17:15:22 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35481 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbfKQWPW (ORCPT ); Sun, 17 Nov 2019 17:15:22 -0500 Received: by mail-wr1-f68.google.com with SMTP id s5so17233416wrw.2 for ; Sun, 17 Nov 2019 14:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uerFL31jjYFZFwF2Yn4Ol5lMqXHtUOh4W1BX0+Oh8Xo=; b=RlIOTDji/oAZb24OubKUw6qBI2cYvttwlHY9TZzaXvr6hSRFdqc2eQ7vone8i6qPk8 jMDtAp5t6TEvoKgux+MKfcTJCu0AB6/XWMAn+eOLZRiE11DdQQM7u0y6IiOcL1zALJBR OTKFL5L2O9pHIYM12/9abPfgYtKkXVNAUnyaaCM65JbXWdWblusGeLzNHDXTS2Sdk2WS AlnjLBOgLNavyb0oG1rf3SKM2Y/MfNsvbP1QqNVw5v/ocOf3Gh/ltVh/tO260iw7MqYO kgM/iUD5KZrZgmRQgTFCVZ3+O8Wqio97U69bVeZn/w7rWPXi5DWKw49dJF5LX9jpMAg2 wWLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uerFL31jjYFZFwF2Yn4Ol5lMqXHtUOh4W1BX0+Oh8Xo=; b=QiGxlMwl0asCnh1gXCQcxnUCC6WU6yYPrzRHAU9dqVxFfcX3N3KmdMiLbpjFpSmxfZ 3nFFhDm5Ykkqzz46BPbNr2hWc1UHn9TCKF3f0HN4F23aP2pkZqnxnloCWrl0U5qvSjW8 m+yIxKkR/VlE4XHqoWux1tTfTHy2VW+lreWm7LSYHlHOIGGQprFBS2VcCljzTNktZkb1 MhkIXy4iy3Dt1oQ+ziToPhGktzt2cQkXFmHsk0KGRQRVFsfb5AQ4lpJr3ECg1hZTd1vU q6SBwuwP+PaWzFRQHWRV+Hc8RK1xcP7x14UGsL/50bEeOOmW2oGBeIFj823MU/YbVys6 KGwA== X-Gm-Message-State: APjAAAX9C1P8TqFqMr7wugym9C9AfaSShuojAOX8PbX8EYhzGFymgiDw kywbNNOvrYtfbYFlZX1ho+uDVOyd X-Received: by 2002:a5d:458d:: with SMTP id p13mr26668429wrq.181.1574028918938; Sun, 17 Nov 2019 14:15:18 -0800 (PST) Received: from localhost.localdomain ([62.201.25.198]) by smtp.gmail.com with ESMTPSA id z8sm20111641wrp.49.2019.11.17.14.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2019 14:15:18 -0800 (PST) From: Petr Vorel To: linux-nfs@vger.kernel.org Cc: Maxime Hadjinlian , Thomas Petazzoni , Petr Vorel Subject: [nfs-utils PATCH 1/1] mountd: Add check for 'struct file_handle' Date: Sun, 17 Nov 2019 23:15:06 +0100 Message-Id: <20191117221506.32084-1-petr.vorel@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Maxime Hadjinlian The code to check if name_to_handle_at() is implemented generates only a warning but with some toolchain it doesn't fail to link (the function must be implemented somewhere). However the "struct file_handle" type is not available. So, this patch adds a check for this struct. Patch taken from buildroot distribution. Signed-off-by: Thomas Petazzoni [ pvorel: rebased from nfs-utils-1-3-4 ] Signed-off-by: Petr Vorel Signed-off-by: Maxime Hadjinlian --- configure.ac | 1 + utils/mountd/cache.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9ba9d4b5..949ff9fc 100644 --- a/configure.ac +++ b/configure.ac @@ -510,6 +510,7 @@ AC_TYPE_PID_T AC_TYPE_SIZE_T AC_HEADER_TIME AC_STRUCT_TM +AC_CHECK_TYPES([struct file_handle]) dnl ************************************************************* dnl Check for functions diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c index 3861f84a..31e9507d 100644 --- a/utils/mountd/cache.c +++ b/utils/mountd/cache.c @@ -446,7 +446,7 @@ static int same_path(char *child, char *parent, int len) if (count_slashes(p) != count_slashes(parent)) return 0; -#if HAVE_NAME_TO_HANDLE_AT +#if defined(HAVE_NAME_TO_HANDLE_AT) && defined(HAVE_STRUCT_FILE_HANDLE) struct { struct file_handle fh; unsigned char handle[128]; -- 2.24.0