Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [nfs-utils PATCH 1/1] mountd: Add check for 'struct file_handle'
To:     Petr Vorel <petr.vorel@gmail.com>, linux-nfs@vger.kernel.org
Cc:     Maxime Hadjinlian <maxime.hadjinlian@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
References: <20191117221506.32084-1-petr.vorel@gmail.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <61828832-a5ef-7aaf-07ac-e9bbf279e104@RedHat.com>
Date:   Mon, 18 Nov 2019 09:02:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191117221506.32084-1-petr.vorel@gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 11/17/19 5:15 PM, Petr Vorel wrote:
> From: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>=20
> The code to check if name_to_handle_at() is implemented generates only a
> warning but with some toolchain it doesn't fail to link (the function mus=
t be
> implemented somewhere).
> However the "struct file_handle" type is not available.
>=20
> So, this patch adds a check for this struct.
>=20
> Patch taken from buildroot distribution.
>=20
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> [ pvorel: rebased from nfs-utils-1-3-4 ]
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Committed... (tag: nfs-utils-2-4-3-rc1)

steved.
> ---
>  configure.ac         | 1 +
>  utils/mountd/cache.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/configure.ac b/configure.ac
> index 9ba9d4b5..949ff9fc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -510,6 +510,7 @@ AC_TYPE_PID_T
>  AC_TYPE_SIZE_T
>  AC_HEADER_TIME
>  AC_STRUCT_TM
> +AC_CHECK_TYPES([struct file_handle])
> =20
>  dnl *************************************************************
>  dnl Check for functions
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index 3861f84a..31e9507d 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -446,7 +446,7 @@ static int same_path(char *child, char *parent, int l=
en)
>  =09if (count_slashes(p) !=3D count_slashes(parent))
>  =09=09return 0;
> =20
> -#if HAVE_NAME_TO_HANDLE_AT
> +#if defined(HAVE_NAME_TO_HANDLE_AT) && defined(HAVE_STRUCT_FILE_HANDLE)
>  =09struct {
>  =09=09struct file_handle fh;
>  =09=09unsigned char handle[128];
>=20