Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2129556ybc; Wed, 20 Nov 2019 09:19:50 -0800 (PST) X-Google-Smtp-Source: APXvYqwvSdWPfh/p+SIiTXrFF0mHrtqhWRMrYKqFdzcYAacFkjktsWM3fDekM6b334Ar7u8vLDCS X-Received: by 2002:a5d:448a:: with SMTP id j10mr5128091wrq.79.1574270390709; Wed, 20 Nov 2019 09:19:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574270390; cv=none; d=google.com; s=arc-20160816; b=jd3zUhxcee2j01ZE0gFV0V3uxVn1YmRIma9YBklkIxkuOGRhBLtpb414guLo0GcOhP K4hWKuGVfxsMHaYd1tch73qaq6UNRo8Q/HoAG8yzyaT3LegfWCWqOFRd0Fm1xjZgXNQ2 OG7YyPWORpCyOrqJrK4VLK2z91uTOLmvdBlrR2oWq2jW++g6OAwjWadGvY5wUvtXqE4g Mktemu3AY2TC2q+tei0hGVaZCvverUhtTqpEV3qO6pBWdPArh5gj+7KeIV5xo8/jlrHX CN1/RKhgz86vflB5QH7ZQxjn6NZEQSUx3xyQ49tj5sIdvLxdnIy3nZ6uAlQO5edYh8nO jNgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=bimceprUZXtgJwJ3r+uNah68s5oKbHDn9kJlulQ0RL0=; b=U+fq5062/WCeYZ1+l/T5UAN/fZMz2NoTdDkOWt8UfB6Y04XaEa4VvR/+DDSm0ysBNN zL1jm0snEGDXohQb+YPqYUc1AQnEEAIH7cy2jSC1AMmcESSxdSSgLMHhgl+3owno8aAU jSlEnswgBZIqAQ+nJmgw6BSx7+omBZcrgZzheSSfbr4B5XaP8F+dWMYpng+Mx4lJNu0G CYgc1zm3c1GWVZ5lmOWjNcQSLt4jq6KYqLivSoBVmZYVxL1e4DG2WG1Fch7xjljCAbSm VI2BsPh6GnxLFTWGdY85gY603qH6ZmANp8+5BtgNu/nvm7704ZFbWw+1L6NFmNZCw2xj hJ3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ir7N0f31; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b18si14921edx.26.2019.11.20.09.19.11; Wed, 20 Nov 2019 09:19:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ir7N0f31; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728554AbfKTP1z (ORCPT + 99 others); Wed, 20 Nov 2019 10:27:55 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42186 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728202AbfKTP1z (ORCPT ); Wed, 20 Nov 2019 10:27:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574263674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bimceprUZXtgJwJ3r+uNah68s5oKbHDn9kJlulQ0RL0=; b=ir7N0f31WFQppZem22qXKeUjilzlcUSl79ltYn9t/JA1AqJ4FRSs7jfQprAxkOExpT+TE9 mSbkWE/5JLYyn18MkDzcvjPMjedqUCba7JDeXEel2Dmb6H36jFWyIajzk96+n3SHp593m0 NUQwhlUgblxlN03OJcE60bdStWJm+Bs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-0lhVNJB-Na6Zu_SXt0PRAQ-1; Wed, 20 Nov 2019 10:27:52 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15515DBAA; Wed, 20 Nov 2019 15:27:51 +0000 (UTC) Received: from coeurl.usersys.redhat.com (ovpn-123-90.rdu2.redhat.com [10.10.123.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4E425E271; Wed, 20 Nov 2019 15:27:50 +0000 (UTC) Received: by coeurl.usersys.redhat.com (Postfix, from userid 1000) id 343142093D; Wed, 20 Nov 2019 10:27:50 -0500 (EST) From: Scott Mayhew To: anna.schumaker@netapp.com, trond.myklebust@hammerspace.com Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 04/27] nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type Date: Wed, 20 Nov 2019 10:27:27 -0500 Message-Id: <20191120152750.6880-5-smayhew@redhat.com> In-Reply-To: <20191120152750.6880-1-smayhew@redhat.com> References: <20191120152750.6880-1-smayhew@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 0lhVNJB-Na6Zu_SXt0PRAQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Al Viro They are identical now. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index 773c347df3ab..d0237d8ffa2b 100644 --- a/fs/nfs/nfs4super.c +++ b/fs/nfs/nfs4super.c @@ -22,8 +22,6 @@ static struct dentry *nfs4_remote_mount(struct file_syste= m_type *fs_type, =09int flags, const char *dev_name, void *raw_data); static struct dentry *nfs4_referral_mount(struct file_system_type *fs_type= , =09int flags, const char *dev_name, void *raw_data); -static struct dentry *nfs4_remote_referral_mount(struct file_system_type *= fs_type, -=09int flags, const char *dev_name, void *raw_data); =20 static struct file_system_type nfs4_remote_fs_type =3D { =09.owner=09=09=3D THIS_MODULE, @@ -33,14 +31,6 @@ static struct file_system_type nfs4_remote_fs_type =3D { =09.fs_flags=09=3D FS_RENAME_DOES_D_MOVE|FS_BINARY_MOUNTDATA, }; =20 -static struct file_system_type nfs4_remote_referral_fs_type =3D { -=09.owner=09=09=3D THIS_MODULE, -=09.name=09=09=3D "nfs4", -=09.mount=09=09=3D nfs4_remote_referral_mount, -=09.kill_sb=09=3D nfs_kill_super, -=09.fs_flags=09=3D FS_RENAME_DOES_D_MOVE|FS_BINARY_MOUNTDATA, -}; - struct file_system_type nfs4_referral_fs_type =3D { =09.owner=09=09=3D THIS_MODULE, =09.name=09=09=3D "nfs4", @@ -111,8 +101,7 @@ nfs4_remote_mount(struct file_system_type *fs_type, int= flags, =09return nfs_fs_mount_common(flags, dev_name, info, &nfs_v4); } =20 -static struct vfsmount *nfs_do_root_mount(struct file_system_type *fs_type= , -=09=09=09=09=09 struct nfs_server *server, int flags, +static struct vfsmount *nfs_do_root_mount(struct nfs_server *server, int f= lags, =09=09=09=09=09 struct nfs_mount_info *info, =09=09=09=09=09 const char *hostname) { @@ -135,7 +124,7 @@ static struct vfsmount *nfs_do_root_mount(struct file_s= ystem_type *fs_type, =09else =09=09snprintf(root_devname, len, "%s:/", hostname); =09info->server =3D server; -=09root_mnt =3D vfs_kern_mount(fs_type, flags, root_devname, info); +=09root_mnt =3D vfs_kern_mount(&nfs4_remote_fs_type, flags, root_devname, = info); =09if (info->server) =09=09nfs_free_server(info->server); =09info->server =3D NULL; @@ -245,7 +234,7 @@ struct dentry *nfs4_try_mount(int flags, const char *de= v_name, =20 =09export_path =3D data->nfs_server.export_path; =09data->nfs_server.export_path =3D "/"; -=09root_mnt =3D nfs_do_root_mount(&nfs4_remote_fs_type, +=09root_mnt =3D nfs_do_root_mount( =09=09=09nfs4_create_server(mount_info, &nfs_v4), =09=09=09flags, mount_info, =09=09=09data->nfs_server.hostname); @@ -259,13 +248,6 @@ struct dentry *nfs4_try_mount(int flags, const char *d= ev_name, =09return res; } =20 -static struct dentry * -nfs4_remote_referral_mount(struct file_system_type *fs_type, int flags, -=09=09=09 const char *dev_name, void *raw_data) -{ -=09return nfs_fs_mount_common(flags, dev_name, raw_data, &nfs_v4); -} - /* * Create an NFS4 server record on referral traversal */ @@ -290,7 +272,7 @@ static struct dentry *nfs4_referral_mount(struct file_s= ystem_type *fs_type, =20 =09export_path =3D data->mnt_path; =09data->mnt_path =3D "/"; -=09root_mnt =3D nfs_do_root_mount(&nfs4_remote_referral_fs_type, +=09root_mnt =3D nfs_do_root_mount( =09=09=09nfs4_create_referral_server(mount_info.cloned, =09=09=09=09=09=09 mount_info.mntfh), =09=09=09flags, &mount_info, data->hostname); --=20 2.17.2