Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2132763ybc; Wed, 20 Nov 2019 09:22:17 -0800 (PST) X-Google-Smtp-Source: APXvYqy7wtVtRs+NfotpmIH4wrrEE1zEc79viVYUMJteeQugL5uRSb96M4GHfdIrFv4XNAhHHU1f X-Received: by 2002:a17:906:4c8c:: with SMTP id q12mr6779860eju.256.1574270537646; Wed, 20 Nov 2019 09:22:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574270537; cv=none; d=google.com; s=arc-20160816; b=GqxIps27BIIqgShINsnhfWN1GJ8nqe5D9FNbxMBepjK9Zsbe5TLhle+0Nyq2ImUKgN insTQl24CyWxgtH/amzYehrCh78+W4xbo4MwnsugQ+ZD0kb55VHKI5Ot0xiAp7txmwOQ Jxd7+EPYybIYQRWlv06SC4XAlz3L29S9xtR7jQKV0Q6OQQidTa+JFywmXXGiABF4UEu5 GOCDBwzNCXY/zoL66gaQvNqb2fgkXjVzTHvGYXqSdf8yatuRIKDpAGI3XCl5+2TmIRr6 xomp7ERTi7HWWO28uozacEJ2bT7l/8uh7Wmqkf/+9bLd0TzWHjSnoezYk6dmc7r2fPRv cKXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ZT8XA04pzr7Tion7Bf7D01EunpSGoMQwu/tEa8+2/Rg=; b=meDk8u0hqovFkMsN9S1OwHNE1p2H0iENrVTTovEDVi+Hj8Ekt05LylpfYsS1Z7wH8s hnsVgPY8tt9kOUpmpn7D8HIOmwTEL7JVTNfvsDH+3bQFlUTZ2/tdRijDltIzjWp3B9u9 eNkqdKjwik0uR/AcFpi1VhD9jd5RBXRsg6Psb4z4CmHLD8SP+lAcrkMO6TymgNTItEzA NRD4ef8r/k+vK6hBjzqsqqqJGubxltfrIL1Y4IYQwWmgd3aOjRmarJU69MM7e7hAv9ys 7udmQphwQoE4pONDNCVM/qvh0azLcEFFcJsdl595IwOjLwDmFSmeUmcbBfjp6yZNX/Zg HvUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ceBouBGF; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cx17si15786867ejb.421.2019.11.20.09.21.52; Wed, 20 Nov 2019 09:22:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ceBouBGF; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730342AbfKTP16 (ORCPT + 99 others); Wed, 20 Nov 2019 10:27:58 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:24831 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729184AbfKTP15 (ORCPT ); Wed, 20 Nov 2019 10:27:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574263676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZT8XA04pzr7Tion7Bf7D01EunpSGoMQwu/tEa8+2/Rg=; b=ceBouBGFhPbFYKYbxS/zoIvLbRGFWhY8x11Tmol7d6ysIqY/eNVrJ0nvV1EfQCiq2puKxl 9CVTykizOQMmmKmn6ck+SivNf8EXjFybSbESIYWcWO2KiBU3CDy1tWbn2x/tIlhFLr3TKs 2QX2nS5J8a5bP43sPZqiqR+v6bs1iUo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-q5GoKa9YNtij467BJS_cbA-1; Wed, 20 Nov 2019 10:27:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF8CD107ACE5; Wed, 20 Nov 2019 15:27:51 +0000 (UTC) Received: from coeurl.usersys.redhat.com (ovpn-123-90.rdu2.redhat.com [10.10.123.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id C083C5C1D4; Wed, 20 Nov 2019 15:27:51 +0000 (UTC) Received: by coeurl.usersys.redhat.com (Postfix, from userid 1000) id 5C871209A5; Wed, 20 Nov 2019 10:27:50 -0500 (EST) From: Scott Mayhew To: anna.schumaker@netapp.com, trond.myklebust@hammerspace.com Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 11/27] nfs: unexport nfs_fs_mount_common() Date: Wed, 20 Nov 2019 10:27:34 -0500 Message-Id: <20191120152750.6880-12-smayhew@redhat.com> In-Reply-To: <20191120152750.6880-1-smayhew@redhat.com> References: <20191120152750.6880-1-smayhew@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: q5GoKa9YNtij467BJS_cbA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Al Viro Make it static, even. And remove a stale extern of (long-gone) nfs_xdev_mount_common() from internal.h, while we are at it. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 --- fs/nfs/super.c | 5 +++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 8f64f2fcc430..dc896602d588 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -396,10 +396,7 @@ bool nfs_auth_info_match(const struct nfs_auth_info *,= rpc_authflavor_t); struct dentry *nfs_try_mount(int, const char *, struct nfs_mount_info *); int nfs_set_sb_security(struct super_block *, struct dentry *, struct nfs_= mount_info *); int nfs_clone_sb_security(struct super_block *, struct dentry *, struct nf= s_mount_info *); -struct dentry *nfs_fs_mount_common(int, const char *, struct nfs_mount_inf= o *); struct dentry *nfs_fs_mount(struct file_system_type *, int, const char *, = void *); -struct dentry * nfs_xdev_mount_common(struct file_system_type *, int, -=09=09const char *, struct nfs_mount_info *); void nfs_kill_super(struct super_block *); void nfs_fill_super(struct super_block *, struct nfs_mount_info *); void nfs_clone_super(struct super_block *, struct nfs_mount_info *); diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 6a27bd501f3f..1587c505cc23 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1893,6 +1893,8 @@ static struct nfs_server *nfs_try_mount_request(struc= t nfs_mount_info *mount_inf =09return nfs_mod->rpc_ops->create_server(mount_info, nfs_mod); } =20 +static struct dentry *nfs_fs_mount_common(int, const char *, struct nfs_mo= unt_info *); + struct dentry *nfs_try_mount(int flags, const char *dev_name, =09=09=09 struct nfs_mount_info *mount_info) { @@ -2648,7 +2650,7 @@ static void nfs_set_readahead(struct backing_dev_info= *bdi, =09bdi->io_pages =3D iomax_pages; } =20 -struct dentry *nfs_fs_mount_common(int flags, const char *dev_name, +static struct dentry *nfs_fs_mount_common(int flags, const char *dev_name, =09=09=09=09 struct nfs_mount_info *mount_info) { =09struct super_block *s; @@ -2730,7 +2732,6 @@ struct dentry *nfs_fs_mount_common(int flags, const c= har *dev_name, =09deactivate_locked_super(s); =09goto out; } -EXPORT_SYMBOL_GPL(nfs_fs_mount_common); =20 struct dentry *nfs_fs_mount(struct file_system_type *fs_type, =09int flags, const char *dev_name, void *raw_data) --=20 2.17.2