Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Nov 2019 16:52:40 +1100 (AEDT)
From:   James Morris <jmorris@namei.org>
To:     Scott Mayhew <smayhew@redhat.com>
cc:     anna.schumaker@netapp.com, trond.myklebust@hammerspace.com,
        David Howells <dhowells@redhat.com>, viro@zeniv.linux.org.uk,
        linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v5 15/27] nfs: get rid of ->set_security()
In-Reply-To: <20191120152750.6880-16-smayhew@redhat.com>
Message-ID: <alpine.LRH.2.21.1911211651220.3625@namei.org>
References: <20191120152750.6880-1-smayhew@redhat.com> <20191120152750.6880-16-smayhew@redhat.com>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Wed, 20 Nov 2019, Scott Mayhew wrote:

> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> it's always either nfs_set_sb_security() or nfs_clone_sb_security(),
> the choice being controlled by mount_info->cloned != NULL.  No need
> to add methods, especially when both instances live right next to
> the caller and are never accessed anywhere else.
> 
> Reviewed-by: David Howells <dhowells@redhat.com>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Please ensure that any changes relating to the LSM API are cc'd to the 
linux-security-module list.


-- 
James Morris
<jmorris@namei.org>