Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: rdma compile error
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <CAN-5tyEPhcE6NBktsqRKySyAUi6EeC_saWFH8A7tKFZ+Sb0jMg@mail.gmail.com>
Date:   Wed, 4 Dec 2019 13:25:01 -0500
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: 7bit
Message-Id: <7D6BD48C-E6B3-43D4-8A31-99F0B387EF77@oracle.com>
References: <CAN-5tyHR8RKtsVNdg6vrSN50Sf9x9XWn-VX0pXBPetAY4Mj7nA@mail.gmail.com>
 <5E198AD1-41F7-4211-83CA-85680D8FB115@oracle.com>
 <CAN-5tyEPhcE6NBktsqRKySyAUi6EeC_saWFH8A7tKFZ+Sb0jMg@mail.gmail.com>
To:     Olga Kornievskaia <aglo@umich.edu>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Dec 4, 2019, at 1:12 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> 
> On Wed, Dec 4, 2019 at 1:02 PM Chuck Lever <chuck.lever@oracle.com> wrote:
>> 
>> Hi Olga-
>> 
>>> On Dec 4, 2019, at 11:15 AM, Olga Kornievskaia <aglo@umich.edu> wrote:
>>> 
>>> Hi Chuck,
>>> 
>>> I git cloned your origin/cel-testing, it's on the following commit.
>>> commit 37e235c0128566e9d97741ad1e546b44f324f108
>>> Author: Chuck Lever <chuck.lever@oracle.com>
>>> Date:   Fri Nov 29 12:06:00 2019 -0500
>>> 
>>>   xprtrdma: Invoke rpcrdma_ep_create() in the connect worker
>>> 
>>> And I'm getting the following compile error.
>>> 
>>> CC [M]  drivers/infiniband/core/cma_trace.o
>>> In file included from drivers/infiniband/core/cma_trace.h:302:0,
>>>                from drivers/infiniband/core/cma_trace.c:16:
>>> ./include/trace/define_trace.h:95:43: fatal error: ./cma_trace.h: No
>>> such file or directory
>>> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>>>                                          ^
>>> Is this known?
>> 
>> I haven't had any complaints from lkp.
>> 
>> f73179592745 ("RDMA/cma: Add trace points in RDMA Connection Manager")
>> 
>> should have added drivers/infiniband/core/cma_trace.h .
>> 
> 
> The file "cma_trace.h" is there in the "core" directory. But for some
> reason my compile expects it to be in include/trace directory (if I
> were to copy it there I can compile).

The end of cma_trace.h should have:

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH .
#define TRACE_INCLUDE_FILE cma_trace

That is supposed to steer the compiler to the cma_trace.h in core/ .

Does a "make mrproper; git clean -d -f -x" help? Feels like there's
a stale generated file somewhere that's breaking things.


--
Chuck Lever