Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191204080039.ixjqetefkzzlldyt@kili.mountain>
 <CAN-5tyEG3C_Ebdr6dpMJ+gQ1pEAMNqbTv76dKu=KK9rspREr1A@mail.gmail.com>
 <20191204220435.GG40361@pick.fieldses.org> <20191205023826.GA43279@pick.fieldses.org>
 <20191206211442.GB17524@fieldses.org> <20191206211538.GC17524@fieldses.org>
In-Reply-To: <20191206211538.GC17524@fieldses.org>
From:   Olga Kornievskaia <olga.kornievskaia@gmail.com>
Date:   Fri, 6 Dec 2019 16:27:24 -0500
Message-ID: <CAN-5tyFO0jXdxpRJewe83kSGWytWfODO20-a7rEd6rS5oP4fmw@mail.gmail.com>
Subject: Re: [bug report] NFSD: allow inter server COPY to have a STALE source
 server fh
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     "J. Bruce Fields" <bfields@redhat.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        linux-nfs <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 6, 2019 at 4:15 PM J. Bruce Fields <bfields@fieldses.org> wrote:
>
> On Fri, Dec 06, 2019 at 04:14:42PM -0500, bfields wrote:
> > On Wed, Dec 04, 2019 at 09:38:26PM -0500, J. Bruce Fields wrote:
> > > So, stuff we could do:
> > >
> > >     - add an extra check of fh_export or something here.
> >
> > So, I'm applying the following for now.
> > +                     if (current->fh->fh_export &&
>                                    ^^^
>
> Um, maybe with a typo or two fixed.
>
>
> > +                                     need_wrongsec_check(rqstp))
> >                               op->status = check_nfsd_access(current_fh->fh_export, rqstp);
> >               }
> >  encode_op:

Sure thing. But I just finished up and have hacked up the client to
send a GETATTR after the 1st PUTFH in the COPY compound of the inter
copy. The server doesn't croak but returns an ERR_STALE on the 1st
PUTFH (I believe this is due to the logic that it's not a valid inter
COPY compound.. so logic works).

but I have nothing against adding the check.