Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Disable statx if using glibc emulation
To:     Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
References: <20191205102736.24314-1-nazard@nazar.ca>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <af515986-dcaa-6a79-6e68-d589ba87568c@RedHat.com>
Date:   Mon, 9 Dec 2019 10:56:25 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191205102736.24314-1-nazard@nazar.ca>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 12/5/19 5:27 AM, Doug Nazar wrote:
> On older kernels without statx, glibc with statx support will attempt
> to emulate the call. However it doesn't support AT_STATX_DONT_SYNC and
> will return EINVAL. This causes all xstat/xlstat calls to fail.
> 
> Signed-off-by: Doug Nazar <nazard@nazar.ca>
Committed... (tag: nfs-utils-2-4-3-rc3)

steved.

> ---
>  support/misc/xstat.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/support/misc/xstat.c b/support/misc/xstat.c
> index 661e29e4..a438fbcc 100644
> --- a/support/misc/xstat.c
> +++ b/support/misc/xstat.c
> @@ -51,6 +51,9 @@ statx_do_stat(int fd, const char *pathname, struct stat *statbuf, int flags)
>  			statx_copy(statbuf, &stxbuf);
>  			return 0;
>  		}
> +		/* glibc emulation doesn't support AT_STATX_DONT_SYNC */
> +		if (errno == EINVAL)
> +			errno = ENOSYS;
>  		if (errno == ENOSYS)
>  			statx_supported = 0;
>  	} else
>