Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: rdma compile error
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <CAN-5tyHmqs2ZWZHKBbockHX_kEcXbnqB=kAfVqtkv-BLhpZHTg@mail.gmail.com>
Date:   Thu, 19 Dec 2019 10:57:36 -0500
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <44C74BBB-3181-4F00-BFD8-784555C80F23@oracle.com>
References: <CAN-5tyHR8RKtsVNdg6vrSN50Sf9x9XWn-VX0pXBPetAY4Mj7nA@mail.gmail.com>
 <5E198AD1-41F7-4211-83CA-85680D8FB115@oracle.com>
 <CAN-5tyEPhcE6NBktsqRKySyAUi6EeC_saWFH8A7tKFZ+Sb0jMg@mail.gmail.com>
 <7D6BD48C-E6B3-43D4-8A31-99F0B387EF77@oracle.com>
 <CAN-5tyHmqs2ZWZHKBbockHX_kEcXbnqB=kAfVqtkv-BLhpZHTg@mail.gmail.com>
To:     Olga Kornievskaia <aglo@umich.edu>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Dec 4, 2019, at 2:09 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
>=20
> On Wed, Dec 4, 2019 at 1:25 PM Chuck Lever <chuck.lever@oracle.com> =
wrote:
>>=20
>>=20
>>=20
>>> On Dec 4, 2019, at 1:12 PM, Olga Kornievskaia <aglo@umich.edu> =
wrote:
>>>=20
>>> On Wed, Dec 4, 2019 at 1:02 PM Chuck Lever <chuck.lever@oracle.com> =
wrote:
>>>>=20
>>>> Hi Olga-
>>>>=20
>>>>> On Dec 4, 2019, at 11:15 AM, Olga Kornievskaia <aglo@umich.edu> =
wrote:
>>>>>=20
>>>>> Hi Chuck,
>>>>>=20
>>>>> I git cloned your origin/cel-testing, it's on the following =
commit.
>>>>> commit 37e235c0128566e9d97741ad1e546b44f324f108
>>>>> Author: Chuck Lever <chuck.lever@oracle.com>
>>>>> Date:   Fri Nov 29 12:06:00 2019 -0500
>>>>>=20
>>>>>  xprtrdma: Invoke rpcrdma_ep_create() in the connect worker
>>>>>=20
>>>>> And I'm getting the following compile error.
>>>>>=20
>>>>> CC [M]  drivers/infiniband/core/cma_trace.o
>>>>> In file included from drivers/infiniband/core/cma_trace.h:302:0,
>>>>>               from drivers/infiniband/core/cma_trace.c:16:
>>>>> ./include/trace/define_trace.h:95:43: fatal error: ./cma_trace.h: =
No
>>>>> such file or directory
>>>>> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>>>>>                                         ^
>>>>> Is this known?
>>>>=20
>>>> I haven't had any complaints from lkp.
>>>>=20
>>>> f73179592745 ("RDMA/cma: Add trace points in RDMA Connection =
Manager")
>>>>=20
>>>> should have added drivers/infiniband/core/cma_trace.h .
>>>>=20
>>>=20
>>> The file "cma_trace.h" is there in the "core" directory. But for =
some
>>> reason my compile expects it to be in include/trace directory (if I
>>> were to copy it there I can compile).
>>=20
>> The end of cma_trace.h should have:
>>=20
>> #undef TRACE_INCLUDE_PATH
>> #define TRACE_INCLUDE_PATH .
>> #define TRACE_INCLUDE_FILE cma_trace
>=20
> It does have it.
>=20
>> That is supposed to steer the compiler to the cma_trace.h in core/ .
>>=20
>> Does a "make mrproper; git clean -d -f -x" help? Feels like there's
>> a stale generated file somewhere that's breaking things.
>=20
> I probably do have something uncleaned. I have tried what you
> suggested but it's not helping. This build is a tar of a git clone
> tree then copied into an internal lab (with rdma hardware).

I found a very similar compile issue yesterday. The fix is in the
current cel-testing topic branch, if you are interested.


--
Chuck Lever