Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2490577ybl; Thu, 19 Dec 2019 14:44:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzHN9skF3Tv4CUwjQktqn2U/4/B/PaBT4WUiq+Wo+OBajkfJIvcxu3I56CwIFFQRvDgi0La X-Received: by 2002:a05:6830:1116:: with SMTP id w22mr11716471otq.216.1576795482159; Thu, 19 Dec 2019 14:44:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576795482; cv=none; d=google.com; s=arc-20160816; b=o4UqAcHA5oDTfkg1qxx4e7zX4kuh1Op74r2n+BymP3M6pTHBvpdyFwqeWvr62ksZ1S LOhXf1E8SCAeKSKEYBXHT84opCNLiPXU8FqYVHvwdUrXCjrpLtrngsdi8BzGJqkDQnMt y1di3x4HKPwb/9+HEPoeekIFXAc1Gt5G2hPLmAnhE9b+Xp64jlBjhvuJslIq0sT/V/6n lDCpm9XZHIPRlKGh/3MGerUYZ/6mSQcW3ui4xlIJhXJdHGLjIPBFftYVF0JdVehc5vzz b5dMXKG0GJ505tO0e+lm111Kc4PuTxZytb/AKI3ikbIQ4sbH7CQ7Bvo5ik1S5rzcbhPz POAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:from:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date; bh=eATmZwlSDh/qfuZ2oHsFQHytkoyGOlDeG2x5RHxjZeY=; b=jCwdiL+EI4Pnwlupkdw6KD7qLbZiLf/fkfpsobguFo1iSBURHfyNJTmbH1WTSx+ETq JgOMCANL4Ipj2bg0zcSg6QTWx0ysWkN6vAC1ONa88sKYKNZvUNCXF3L9vwXxC4Eqo5sT q1xIFUQrbFeO1dra6/rpE67O/qUI/L/wNAtQwxQDtGpR26di6fdoq7KxbhOHUqJRg+O8 vrSCuL14cgZBalDXH9gUNxCYyRsFTY9/8AlX+JvMNq+62urrh7UGf1E6G3ake301TCwU geYWCF/28oGz2GC9J/ZA/cZqWy2Bg4EfSKtnRJwdbZs0MOs+1eFJ5GuhhkCQ5xdbp5uS h6EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si3563405oij.136.2019.12.19.14.44.31; Thu, 19 Dec 2019 14:44:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfLSWo3 (ORCPT + 99 others); Thu, 19 Dec 2019 17:44:29 -0500 Received: from fieldses.org ([173.255.197.46]:38786 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbfLSWo3 (ORCPT ); Thu, 19 Dec 2019 17:44:29 -0500 Received: by fieldses.org (Postfix, from userid 2815) id 705AB1C7C; Thu, 19 Dec 2019 17:44:29 -0500 (EST) Date: Thu, 19 Dec 2019 17:44:29 -0500 To: Dave Chinner Cc: Trond Myklebust , "J. Bruce Fields" , linux-nfs@vger.kernel.org Subject: Re: [PATCH v2] nfsd: Clone should commit src file metadata too Message-ID: <20191219224429.GE12026@fieldses.org> References: <20191218195723.395277-1-trond.myklebust@hammerspace.com> <20191218211251.GX19213@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218211251.GX19213@dread.disaster.area> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Dec 19, 2019 at 08:12:51AM +1100, Dave Chinner wrote: > On Wed, Dec 18, 2019 at 02:57:23PM -0500, Trond Myklebust wrote: > > vfs_clone_file_range() can modify the metadata on the source file too, > > so we need to commit that to stable storage as well. > > > > Reported-by: Dave Chinner > > Signed-off-by: Trond Myklebust > > Looks ok to me now. > > Acked-by: Dave Chinner Thanks! Applying for 5.6, with Dave's ACK.--b.