Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Jan 2020 11:53:29 -0500
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     NeilBrown <neilb@suse.de>
Cc:     Trond Myklebust <trondmy@hammerspace.com>,
        "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH/RFC] NFS: handle NFSv4.1 server that doesn't support
 NFS4_OPEN_CLAIM_DELEG_CUR_FH
Message-ID: <20200107165329.GB944@fieldses.org>
References: <87y2v9fdz8.fsf@notabene.neil.brown.name>
 <3afd2d5c631d8e3429e025e204a7b1c95b3c1415.camel@hammerspace.com>
 <87v9qdf2gh.fsf@notabene.neil.brown.name>
 <d3299fefa94d6959d848b765ce60e2467ce1b253.camel@hammerspace.com>
 <87pngkg9ga.fsf@notabene.neil.brown.name>
 <9f5f220e64245d7f1b0359149876b5dc056dcf12.camel@hammerspace.com>
 <87lfr7fu9v.fsf@notabene.neil.brown.name>
 <20200107161536.GA944@fieldses.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200107161536.GA944@fieldses.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 07, 2020 at 11:15:36AM -0500, bfields wrote:
> On Fri, Dec 20, 2019 at 04:19:56PM +1100, NeilBrown wrote:
> > I was a bit surprised that nfs4_map_atomic_open_claim() exists at all,
> > but given that it did, I assumed it would be used more uniformly.
> > 
> > So this all implies that Linux NFS server claimed to support NFSv4.1
> > before it actually did - which seems odd.  This is just a bug (which are
> > expected), but a clear ommission.
> 
> For what it's worth, I did make some attempt to keep 4.1 by default

(I meant to say: "keep 4.1 off by default".)

> until 3.11 (see d109148111cd "nfsd4: support minorversion 1 by default")
> but probably could have communicated that better.  This isn't the only
> blatant known issue in older code.
> 
> --b.