Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Jan 2020 22:19:14 +0100
From:   Christian =?utf-8?Q?Bartolom=C3=A4us?= <use_v6@aglaz.de>
To:     linux-nfs@vger.kernel.org
Subject: [PATCH] mountd: Remove outdated/misleading comment
Message-ID: <20200107211914.GE4452@cus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
("mountd: fix mount issue due to comparison with uninitialized uuid") was
applied back in 2015. The final case of the switch statement no longer ends
with a 'return true' and the final 'return false' is relevant now.

Signed-off-by: Christian Bartolomäus <use_v6@aglaz.de>
---
 utils/mountd/cache.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index e5186c7..8f54e37 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
 				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) == 0)
 					return true;
 	}
-	/* Well, unreachable, actually: */
 	return false;
 }