Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3942672ybl; Mon, 13 Jan 2020 05:24:16 -0800 (PST) X-Google-Smtp-Source: APXvYqwSidjeW+ewLkNQACMnRbxgtwu+r04UPOt3fHmXbqBAviAfzmARMENiVBXdoV2oZOn8n3P4 X-Received: by 2002:aca:e146:: with SMTP id y67mr12034554oig.93.1578921856776; Mon, 13 Jan 2020 05:24:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578921856; cv=none; d=google.com; s=arc-20160816; b=SFDslzw5W5VcYm7pYw3HyyGD2cuYrhW+AMZH3IdALHoQz/gExyPBHnRKfysoLT2g6y iSgkqXrFTe3BqwMrmd+6AWlbYuRjEyJMM8qFiX1N36JsOd7h7uP4DcwIhviHQttrns0t mpts0/L5/Klbh7lVEcI+a6GdjeSJR30g3Z+r2OuZ35D3csklMHfbnjqWuvJOkdj96gP1 jMlKowVBWB82a+jQ7zuNCwRjyIyw2/vkEWgcLMOSI41snRVyMSEWrUZJXyhZn0N/J68y 59AXXvauCgvhXDn4x+5sh3bB0Z8yb2YDqPoe4EK4Zc+DOK+NzFGIIXrBRFn8QKCWVcdt UmKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=8OZxeanEuptXF8CJ0FdPIwRdmEuBYU+V1UcaAab/WP4=; b=t45zwfGgC6+TG0rAoGfFaV4Aaj8Psax0tyBoxCmr9Eaf93Qc5e/VBeLnFFwOlwlyt5 EVBBKR9IV08gCn2n/5RG2C/Z0dcGp+6Tcm13KSsuW3J8FytC/NwBtKkpVRUHkIxLPmQa RGj+IFaFNMEZEGdOP7rNEuwKk2u1lj36vAnWEq5BlfMzldjgCp/4x8Kf1E/PxMfQWRtJ YNrEnb5247bsTXQV9GMRnP8/AQx1/XkWZ+3PTj1L4d6k4qnkW68NUTCSJ7qRYhqJJgP4 3IY3u/ed0K/4q+X1AY8Lu6HtCRx1oOFUWWLChEUC/5OiVNqTJwQ8ibWxbhfJ44js3COp LUog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=alF88qWn; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si6876411oti.273.2020.01.13.05.23.55; Mon, 13 Jan 2020 05:24:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=alF88qWn; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgAMNXz (ORCPT + 99 others); Mon, 13 Jan 2020 08:23:55 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:39564 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbgAMNXz (ORCPT ); Mon, 13 Jan 2020 08:23:55 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00DDMe1h091442; Mon, 13 Jan 2020 13:23:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2019-08-05; bh=8OZxeanEuptXF8CJ0FdPIwRdmEuBYU+V1UcaAab/WP4=; b=alF88qWnhtZBwRxjsDU+LhxfvFBhR8wdyI+nL8HIQYD7YOU859JkAYSrHQFjj3fsenhd XvPaAPm2M7lQmDJKzhHQtmJcZzU8HvquwNQFO6ASTQea2tmtMERPad/lnnUnovDK0SVW neiRQhgdgYq8tMOQ3YH32A8NztpVVb+TyB4xooUMO/CcaRXMZm/G9hQjxPzAQ5q8K389 4RRFtevsA63LWAKWJDgaRdYI02HNCkTkroVM9aVRul7jC9LEGlzeVDtqAbFzuZUJA1cZ H/85nOqumdRDi9bX1Jhj9Bjh8aN0decsUWpzmsS9aUw1Svn+k8sXnnlgfaR0HT89oRdE AQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2xf73y6vnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2020 13:23:49 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00DDNnvl154646; Mon, 13 Jan 2020 13:23:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2xfqu4hufy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2020 13:23:49 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00DDNEGb024717; Mon, 13 Jan 2020 13:23:14 GMT Received: from kili.mountain (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Jan 2020 05:23:14 -0800 Date: Mon, 13 Jan 2020 16:23:07 +0300 From: Dan Carpenter To: "J. Bruce Fields" , Olga Kornievskaia Cc: Chuck Lever , linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] nfsd4: fix double free in nfsd4_do_async_copy() Message-ID: <20200113132307.frp6ur5zhzolu5ys@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9498 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001130112 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9498 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001130112 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This frees "copy->nf_src" before and again after the goto. Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy") Signed-off-by: Dan Carpenter --- fs/nfsd/nfs4proc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 1e14b3ed5674..c90c24c35b2e 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1469,7 +1469,6 @@ static int nfsd4_do_async_copy(void *data) copy->nf_src->nf_file = nfs42_ssc_open(copy->ss_mnt, ©->c_fh, ©->stateid); if (IS_ERR(copy->nf_src->nf_file)) { - kfree(copy->nf_src); copy->nfserr = nfserr_offload_denied; nfsd4_interssc_disconnect(copy->ss_mnt); goto do_callback; -- 2.11.0