Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential
 -Wformat-nonliteral warning
To:     linux-nfs@vger.kernel.org, Steve Dickson <SteveD@RedHat.com>
References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com>
 <20200103215039.27471-6-giulio.benetti@benettiengineering.com>
From:   Giulio Benetti <giulio.benetti@benettiengineering.com>
Message-ID: <dd75fa26-a07a-49fb-ed22-1e60da31c8da@benettiengineering.com>
Date:   Wed, 15 Jan 2020 17:29:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200103215039.27471-6-giulio.benetti@benettiengineering.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

you've missed this patch while applying the series. Can you please 
commit it?

Thank you
Kind regards
-- 
Giulio Benetti
Benetti Engineering sas

On 1/3/20 10:50 PM, Giulio Benetti wrote:
> format and vecformat must be declared as "char * const" to be really
> treated as constant when building with -Werror=format-nonliteral,
> otherwise compiler will consider them subject to change throughout the
> function.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   tools/rpcgen/rpc_cout.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/rpcgen/rpc_cout.c b/tools/rpcgen/rpc_cout.c
> index f806a86a..df2609c4 100644
> --- a/tools/rpcgen/rpc_cout.c
> +++ b/tools/rpcgen/rpc_cout.c
> @@ -319,8 +319,8 @@ emit_union(definition *def)
>     case_list *cl;
>     declaration *cs;
>     char *object;
> -  char *vecformat = "objp->%s_u.%s";
> -  char *format = "&objp->%s_u.%s";
> +  char * const vecformat = "objp->%s_u.%s";
> +  char * const format = "&objp->%s_u.%s";
>   
>     print_stat(1,&def->def.un.enum_decl);
>     f_print(fout, "\tswitch (objp->%s) {\n", def->def.un.enum_decl.name);
>