Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Trond Myklebust" <trondmy@hammerspace.com>
Cc:     anna.schumaker@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFS: Don't skip lookup when holding a delegation
Date:   Thu, 16 Jan 2020 11:32:01 -0500
Message-ID: <C5892E37-4731-4AD5-97FE-D8151C289CE9@redhat.com>
In-Reply-To: <d8639ad40df3b0a814e7396e1e824220c4d21a55.camel@hammerspace.com>
References: <77be993185fa7f114f6856f74f2f7affb5bd411d.1568904510.git.bcodding@redhat.com>
 <6399DBA2-DA9D-40C3-80BC-6DCE94BB9C49@redhat.com>
 <d8639ad40df3b0a814e7396e1e824220c4d21a55.camel@hammerspace.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On 16 Jan 2020, at 11:02, Trond Myklebust wrote:
> We should need to perform this revalidation once, and only once for
> that directory, and only if we opened the file using a CLAIM_FH open,
> or if we opened it through a different hard linked name (and did not
> create this hard link after we got the delegation).
>
> Perhaps we could define a magic value for dentry->d_time that causes us
> to skip revalidation if and only if we hold a delegation?

Can we put the delegation's change_attr in d_time for dentries that have
been revalided while holding a delegation?

Ben