Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential
 -Wformat-nonliteral warning
To:     Steve Dickson <SteveD@RedHat.com>, linux-nfs@vger.kernel.org
References: <20200103215039.27471-1-giulio.benetti@benettiengineering.com>
 <20200103215039.27471-6-giulio.benetti@benettiengineering.com>
 <dd75fa26-a07a-49fb-ed22-1e60da31c8da@benettiengineering.com>
 <a9f351c6-22e5-35ef-7119-d261ef8d0159@RedHat.com>
From:   Giulio Benetti <giulio.benetti@benettiengineering.com>
Message-ID: <4950679e-f8d0-c9ce-b08d-62801acd2c12@benettiengineering.com>
Date:   Thu, 16 Jan 2020 21:38:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <a9f351c6-22e5-35ef-7119-d261ef8d0159@RedHat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On 1/16/20 9:07 PM, Steve Dickson wrote:
> 
> 
> On 1/15/20 11:29 AM, Giulio Benetti wrote:
>> Hi Steve,
>>
>> you've missed this patch while applying the series. Can you please commit it?
> It is in...
> 
> commit 6f4568f1f7395f967cc03995dcfb79a1ac5c11cd
> Author: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Date:   Mon Jan 6 14:23:04 2020 -0500
> 
>      rpcgen: rpc_hout: fix potential -Wformat-security warning
>      
>      f_print()'s argument "separator" is not known because it's passed as an
>      argument and with -Wformat-security will cause a useless warning. Let's
>      ignore by adding "#pragma GCC diagnostic ignored/warning" before and
>      after f_print().
>      
>      Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>      Signed-off-by: Steve Dickson <steved@redhat.com>
> 
> what am I missing?

Ah you've merged them together, now I see:
[5/7] https://patchwork.kernel.org/patch/11317493/
[6/7] https://patchwork.kernel.org/patch/11317489/

I didn't notice it while pull rebasing from upstream, because I have 
another patch similar to that after bumping to latest version of rpcgen.

Sorry for the noise and thank you!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas