Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mountd: Remove outdated/misleading comment
To:     =?UTF-8?Q?Christian_Bartolom=c3=a4us?= <use_v6@aglaz.de>,
        linux-nfs@vger.kernel.org
References: <20200107211914.GE4452@cus>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <c3735526-a8c6-585a-ef28-7e2122f7c406@RedHat.com>
Date:   Thu, 16 Jan 2020 15:49:08 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200107211914.GE4452@cus>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 1/7/20 4:19 PM, Christian Bartolom=C3=A4us wrote:
> It became wrong when commit 78240c41be17bd20d5fb5b70b6f470d8e779adee
> ("mountd: fix mount issue due to comparison with uninitialized uuid") w=
as
> applied back in 2015. The final case of the switch statement no longer =
ends
> with a 'return true' and the final 'return false' is relevant now.
>=20
> Signed-off-by: Christian Bartolom=C3=A4us <use_v6@aglaz.de>
Committed... (tag: nfs-utils-2-4-3-rc5)

steved.

> ---
>  utils/mountd/cache.c |    1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index e5186c7..8f54e37 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -672,7 +672,6 @@ static bool match_fsid(struct parsed_fsid *parsed, =
nfs_export *exp, char *path)
>  				if (memcmp(u, parsed->fhuuid, parsed->uuidlen) =3D=3D 0)
>  					return true;
>  	}
> -	/* Well, unreachable, actually: */
>  	return false;
>  }
>=20