Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 17 Jan 2020 07:30:32 +0100
From:   Petr Vorel <petr.vorel@gmail.com>
To:     Steve Dickson <SteveD@redhat.com>
Cc:     Giulio Benetti <giulio.benetti@benettiengineering.com>,
        linux-nfs@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [nfs-utils PATCH 0/3] bump rpcgen version and silence some
 warning
Message-ID: <20200117063032.GA6351@dell5510>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
References: <20200113162918.77144-1-giulio.benetti@benettiengineering.com>
 <30b28d4e-71a5-f412-23e7-877a4eff17bd@RedHat.com>
 <fdbade7a-f8f6-16b1-1a18-e9742b9a0aa0@benettiengineering.com>
 <6fdcbba5-e965-fe69-569b-7f32005ce1bf@benettiengineering.com>
 <c1e96762-0f3a-b465-da1b-f7bc7a687948@RedHat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c1e96762-0f3a-b465-da1b-f7bc7a687948@RedHat.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi Steve, Giulio,

[Cc: Mike]

> On 1/16/20 3:44 PM, Giulio Benetti wrote:
> > On 1/16/20 9:41 PM, Giulio Benetti wrote:
> >> On 1/16/20 9:37 PM, Steve Dickson wrote:


> >>> On 1/13/20 11:29 AM, Giulio Benetti wrote:
> >>>> Giulio Benetti (3):
> >>>> ??? rpcgen: bump to latest version
> >>>> ??? rpcgen: rpc_cout: silence format-nonliteral
> >>>> ??? support: nfs: rpc_socket: silence unused parameter warning on salen

> >>>> ?? support/nfs/rpc_socket.c?? |??? 2 +
> >>>> ?? tools/rpcgen/Makefile.am?? |?? 24 +-
> >>>> ?? tools/rpcgen/proto.h?????? |?? 65 ++
> >>>> ?? tools/rpcgen/rpc_clntout.c |? 458 +++++---
> >>>> ?? tools/rpcgen/rpc_cout.c??? | 1269 ++++++++++++----------
> >>>> ?? tools/rpcgen/rpc_hout.c??? |? 915 +++++++++-------
> >>>> ?? tools/rpcgen/rpc_main.c??? | 2083 +++++++++++++++++++++---------------
> >>>> ?? tools/rpcgen/rpc_parse.c?? | 1055 +++++++++---------
> >>>> ?? tools/rpcgen/rpc_parse.h?? |? 103 +-
> >>>> ?? tools/rpcgen/rpc_sample.c? |? 465 ++++----
> >>>> ?? tools/rpcgen/rpc_scan.c??? |? 812 +++++++-------
> >>>> ?? tools/rpcgen/rpc_scan.h??? |?? 91 +-
> >>>> ?? tools/rpcgen/rpc_svcout.c? | 1647 +++++++++++++++-------------
> >>>> ?? tools/rpcgen/rpc_tblout.c? |? 265 ++---
> >>>> ?? tools/rpcgen/rpc_util.c??? |? 656 ++++++------
> >>>> ?? tools/rpcgen/rpc_util.h??? |? 170 ++-
> >>>> ?? tools/rpcgen/rpcgen.1????? |? 442 ++++++++
> >>>> ?? 17 files changed, 6123 insertions(+), 4399 deletions(-)
> >>>> ?? create mode 100644 tools/rpcgen/proto.h
> >>>> ?? create mode 100644 tools/rpcgen/rpcgen.1

> >>> Committed... (tag nfs-utils-2-4-3-rc5)... Nice work!!!

> >> Wooho! Thank you :-)

> >> As soon as you release version 2.4.3 I'm going to bump version in
> >> Buildroot too, at the moment it's still 1.3.4.

> > Ah, I've forgot that on xtensa it fails building and need this patch to be applied to:
> > https://patchwork.kernel.org/patch/11335261/

> > If you have the chance to commit before releasing version it would be great!
> Your patch on my radar... but... conflicts  with Petr's cross-compilation patch
> https://lore.kernel.org/linux-nfs/20200114183603.GA24556@dell5510/T/#t

> That patch causes an automake warnings which is something I'm trying to avoid.

> No worries... I will not do a release w/out your patch.... or something close to it. 

Giulio, thanks for your patch. I'll have a look on it over a weekend.
Maybe Mike's cross-compilation patch is really not needed.

> steved.

Kind regards,
Petr