Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 19 Jan 2020 19:45:01 +0100
From:   Petr Vorel <petr.vorel@gmail.com>
To:     Steve Dickson <SteveD@redhat.com>
Cc:     Giulio Benetti <giulio.benetti@benettiengineering.com>,
        linux-nfs@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [nfs-utils PATCH 0/3] bump rpcgen version and silence some
 warning
Message-ID: <20200119184501.GA11432@dell5510>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
References: <20200113162918.77144-1-giulio.benetti@benettiengineering.com>
 <30b28d4e-71a5-f412-23e7-877a4eff17bd@RedHat.com>
 <fdbade7a-f8f6-16b1-1a18-e9742b9a0aa0@benettiengineering.com>
 <6fdcbba5-e965-fe69-569b-7f32005ce1bf@benettiengineering.com>
 <c1e96762-0f3a-b465-da1b-f7bc7a687948@RedHat.com>
 <20200117063032.GA6351@dell5510>
 <818c66c5-6f8b-927f-229e-52a00f50c682@RedHat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <818c66c5-6f8b-927f-229e-52a00f50c682@RedHat.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi all,

> On 1/17/20 1:30 AM, Petr Vorel wrote:
> >>> If you have the chance to commit before releasing version it would be great!
> >> Your patch on my radar... but... conflicts  with Petr's cross-compilation patch
> >> https://lore.kernel.org/linux-nfs/20200114183603.GA24556@dell5510/T/#t

> >> That patch causes an automake warnings which is something I'm trying to avoid.

> >> No worries... I will not do a release w/out your patch.... or something close to it. 

> > Giulio, thanks for your patch. I'll have a look on it over a weekend.
> > Maybe Mike's cross-compilation patch is really not needed.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>
NOTE: as I understand it's a compilation issue of a tool, so I didn't run
rpcgen, I just test various compilation variants.

Considering recently merged Giulio's change in tools/rpcgen/Makefile.am
e61775d1 ("rpcgen: bump to latest version") I'm for trying this one.

I tested buildroot compilation of Giulio's changes [1] [2] and it works.
Notable change is to move from nfs-utils' internal rpcgen to external one from system
(replace --with-rpcgen=internal with --with-rpcgen=$(HOST_DIR)/bin/rpcgen in [2]).
IMHO Mike's patch is not needed for buildroot.

@Mike, could you please test it for Gentoo?

Looking at Gentoo package history, all packages [3] [4] [5] use rpcgen from system
(--with-rpcgen). This change was added 2 years ago for, nfs-utils 2.3.x [6];
but Mike's patch was here at least 5 years ago [7], for nfs-utils 1.2.x and
1.3.x (actually sent to ML in 2013-03-25 [8], so for 1.2.x?), so the patch might
not be needed any more since then anyway.

BTW NEWS file for nfs-utils 1.1.0 states that by default use rpcgen from system,
so it looks to me that at the time of Mike's patch needed for Gentoo it was also
using internal rpcgen, but maybe I'm wrong.

Kind regards,
Petr

[1] https://github.com/giuliobenetti/nfs-utils/commit/c45edd7a5d5aa51c735017a7fd4fd89948ad05b2
[2] https://github.com/giuliobenetti/buildroot/commit/e4ae0d0e33e61858701bfe44e9777f7c69584706
[3] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.3.4.ebuild
[4] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.4.1-r4.ebuild
[5] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-fs/nfs-utils/nfs-utils-2.4.2-r1.ebuild
[6] https://gitweb.gentoo.org/repo/gentoo.git/commit/net-fs/nfs-utils?id=d3c1580e4b5e583a457055f1a01818269e65459f
[7] https://gitweb.gentoo.org/repo/gentoo.git/commit/net-fs/nfs-utils?id=56bd759df1d0c750a065b8c845e93d5dfa6b549d
[8] https://lore.kernel.org/linux-nfs/1364163668-15490-1-git-send-email-vapier@gentoo.org/