Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 19 Jan 2020 20:10:47 +0100
From:   Petr Vorel <petr.vorel@gmail.com>
To:     Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc:     linux-nfs@vger.kernel.org, Steve Dickson <SteveD@redhat.com>,
        Mike Frysinger <vapier@gentoo.org>
Subject: Re: [nfs-utils PATCH] locktest: Makefile.am: remove host compiler
 costraint
Message-ID: <20200119191047.GB11432@dell5510>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
References: <20200115160806.99991-1-giulio.benetti@benettiengineering.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200115160806.99991-1-giulio.benetti@benettiengineering.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

Hi,

> Currently locktest can be built only for host because CC_FOR_BUILD is
> specified as CC, but this leads to build failure when passing CFLAGS not
> available on host gcc(i.e. -mlongcalls) and most of all locktest would
> be available on target systems the same way as rpcgen etc. So remove CC
> and LIBTOOL assignments.

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>
NOTE: as I understand it's a compilation issue of a tool, so I didn't run
rpcgen, I just test various compilation variants for buildroot.

Kind regards,
Petr

> ---
>  tools/locktest/Makefile.am | 3 ---
>  1 file changed, 3 deletions(-)

> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
> index 3156815d..e8914655 100644
> --- a/tools/locktest/Makefile.am
> +++ b/tools/locktest/Makefile.am
> @@ -1,8 +1,5 @@
>  ## Process this file with automake to produce Makefile.in

> -CC=$(CC_FOR_BUILD)
> -LIBTOOL = @LIBTOOL@ --tag=CC
> -
>  noinst_PROGRAMS = testlk
>  testlk_SOURCES = testlk.c
>  testlk_CFLAGS=$(CFLAGS_FOR_BUILD)