Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Robert Milkowski' <rmilkowski@gmail.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        'Trond Myklebust' <trondmy@hammerspace.com>
CC:     'Anna Schumaker' <anna.schumaker@netapp.com>,
        'Chuck Lever' <chuck.lever@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        'Trond Myklebust' <trond.myklebust@hammerspace.com>
Subject: RE: [PATCH v4] NFSv4.0: nfs4_do_fsinfo() should not do implicit lease
 renewals
Thread-Topic: [PATCH v4] NFSv4.0: nfs4_do_fsinfo() should not do implicit
 lease renewals
Thread-Index: AdXV6tGXVv4pqJJkS9G0izuAHIy3vAAzr9Pw
Date:   Wed, 29 Jan 2020 15:35:18 +0000
Message-ID: <1d098aa2dfea466a9aaa4c55353221e2@AcuMS.aculab.com>
References: <004e01d5d5ed$5e7ca490$1b75edb0$@gmail.com>
In-Reply-To: <004e01d5d5ed$5e7ca490$1b75edb0$@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

From: Robert Milkowski
> Sent: 28 January 2020 15:13
> 
> Currently, each time nfs4_do_fsinfo() is called it will do an implicit
> NFS4 lease renewal, which is not compliant with the NFS4 specification.
> This can result in a lease being expired by an NFS server.
...
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 76d3716..7b2d88b 100644
...
> +	if(status == 0)

Whitespace
	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)