Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3130624ybl; Sun, 2 Feb 2020 15:26:58 -0800 (PST) X-Google-Smtp-Source: APXvYqwEj4DIbhuunwYPKGvFCSaBxA1nQ75DiK22Q3m7dpxkJ3pkG7yA2gHsqGujxj0Sh2E1VALV X-Received: by 2002:a9d:798e:: with SMTP id h14mr15311487otm.257.1580686018813; Sun, 02 Feb 2020 15:26:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580686018; cv=none; d=google.com; s=arc-20160816; b=bS3TCDlVgy4lfF50fknIxtRipDFW2jDpF3Z4wN6dlvwktR4zXT6pAqVjryRQRy96lM HFa4USUSspv6Ul+W3zuqBZJ0UbH/iHZN0jk9NbGcTWcvmD69TL0lPWiIHyqj6JkJ55DO OKz2jmHpP+uwolJMu2Kh/YY4JS9Q9KJrYLrAbuXfIR0n9pdL2wA95W3vXB/qNg8Fuloc StyqTkzJBSzhD2Ph9LHVK8kYE5eKg+3y9/36gBc3zVsGFThtF3mooZiuOKy3faCn0cRY R6Wud/ykyypkTW08FmlaJSIUjWTekkWeFTkGn0e3cSZKYHYwEb2lrl7ECxyn3BzmIQeu IxkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sbpll5m/D2jqhS1yNNOSxZ189BRV9Du6vR6MiDbVdEg=; b=C5wfQ3lVkwhmgD/AEUpY2GQsvesGEJBEk47vHYXoblM6i1sVs0DCrYDHMKzJM63tF1 JjQFSu/FFwO8hOtyrHS8hAxHxbUi/kW013uOPgUwgfb3kfaAYjrTxZuRfcsCEOXX4yfJ T/Fk8NK4ikxyg6XW96hD9UnirL8gUDiIVD9MlPasnwd0ai1gzqytzaDetcWEHLJLO2UO R2PgKRoMp/xgQgsL+CQ2sLZqTVTfQBBSgLyGW2vNc9R42j7nFhwCtxpvCJ12+vxcrWgI FZM++4NO5sWhrKXWrR/2R/E4BVJXzoQF/l4Y2nkTDEN+AhRSlawy4VaiQ0VzAWfE9mxT QELQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qri7e740; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si9863382otg.248.2020.02.02.15.26.41; Sun, 02 Feb 2020 15:26:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qri7e740; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgBBW4M (ORCPT + 99 others); Sun, 2 Feb 2020 17:56:12 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:39193 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbgBBW4M (ORCPT ); Sun, 2 Feb 2020 17:56:12 -0500 Received: by mail-yw1-f67.google.com with SMTP id h126so11955263ywc.6 for ; Sun, 02 Feb 2020 14:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sbpll5m/D2jqhS1yNNOSxZ189BRV9Du6vR6MiDbVdEg=; b=qri7e740zzgZdFTplW+u/98OCbz+VhxrxPJEAloQXSOjPSurjFgo9A6/TL5i266n1J zKhAUsBxlbCqTNtvCCT0nfk6CX9/d7p89ImE//+q6Nf7ht+Y3vJgzSagh5SOwVBiz/ws QKLV9ktFf1mH4Z81cPnsGta2t7eAqivLWuT9pyxmDDzoZivR+Y2goZ4U4pasT0W1spzU hkFr7nOlUxS/qErcWgJQputOvZcnqcA+YCd6T5yYsdpn9pd4qS/QrWT6hnLGFRP3h5iJ UOdZallwz9mzcxpTxL6zljvHwV19YJeNipY/Z2j13hAKASiJMg2dZNnLtJYu4+aWf4Nc pmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sbpll5m/D2jqhS1yNNOSxZ189BRV9Du6vR6MiDbVdEg=; b=CnuQ1ML9VCTpQIv7D5poEfBBpYIoDJhRqqNxG4GuNqOnV6XX2UFE7ZVY6+dYBhLKnp PZE3vECTPTVcuJv6YSRDqzjrv6Bf5yIJfvM/62+zdikMAt2oXhaZ/aPlCHd9TcDWXRk+ nYXImjPFM4ImuCiWNS9z2dq9ltfA2KTT+PLjC4wAWWPitOfQdoNdNNWKxXFDKLcGfa+f FWRB14w2+6jn5nNEpH6rEdzV+SzoXHQ/LPMRaoxHCji93+Szk3Wx88RQPNbT6sWSycku 6LJYBTdL8WWGJD8AgD47cSV0B7h+n8Ot9Qw5uAs1cRCQjF211mvPBkoHI0lpKnG066ub K9Bg== X-Gm-Message-State: APjAAAVbREu7x19A8mNa8A6+wCanNxttxJKGVUxnaYjlm1MrjruUJTe8 jPOUJxhQtByIJfRU83bhWw== X-Received: by 2002:a25:664e:: with SMTP id z14mr16706236ybm.75.1580684171200; Sun, 02 Feb 2020 14:56:11 -0800 (PST) Received: from localhost.localdomain (c-68-40-189-247.hsd1.mi.comcast.net. [68.40.189.247]) by smtp.gmail.com with ESMTPSA id u136sm7185529ywf.101.2020.02.02.14.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Feb 2020 14:56:10 -0800 (PST) From: Trond Myklebust X-Google-Original-From: Trond Myklebust To: Anna Schumaker Cc: Benjamin Coddington , Dai Ngo , linux-nfs@vger.kernel.org Subject: [PATCH 4/4] NFS: Switch readdir to using iterate_shared() Date: Sun, 2 Feb 2020 17:53:56 -0500 Message-Id: <20200202225356.995080-5-trond.myklebust@hammerspace.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200202225356.995080-4-trond.myklebust@hammerspace.com> References: <20200202225356.995080-1-trond.myklebust@hammerspace.com> <20200202225356.995080-2-trond.myklebust@hammerspace.com> <20200202225356.995080-3-trond.myklebust@hammerspace.com> <20200202225356.995080-4-trond.myklebust@hammerspace.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Now that the page cache locking is repaired, we should be able to switch to using iterate_shared() for improved concurrency when doing readdir(). Signed-off-by: Trond Myklebust --- fs/nfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 60387dec9032..803e6fec0266 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -58,7 +58,7 @@ static void nfs_readdir_clear_array(struct page*); const struct file_operations nfs_dir_operations = { .llseek = nfs_llseek_dir, .read = generic_read_dir, - .iterate = nfs_readdir, + .iterate_shared = nfs_readdir, .open = nfs_opendir, .release = nfs_closedir, .fsync = nfs_fsync_dir, -- 2.24.1