Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Trond Myklebust" <trondmy@gmail.com>
Cc:     "Anna Schumaker" <Anna.Schumaker@netapp.com>,
        "Dai Ngo" <dai.ngo@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 4/4] NFS: Switch readdir to using iterate_shared()
Date:   Mon, 03 Feb 2020 09:41:57 -0500
Message-ID: <03CF6022-FEF6-48D4-9F55-7A7ED9DE6542@redhat.com>
In-Reply-To: <20200202225356.995080-5-trond.myklebust@hammerspace.com>
References: <20200202225356.995080-1-trond.myklebust@hammerspace.com>
 <20200202225356.995080-2-trond.myklebust@hammerspace.com>
 <20200202225356.995080-3-trond.myklebust@hammerspace.com>
 <20200202225356.995080-4-trond.myklebust@hammerspace.com>
 <20200202225356.995080-5-trond.myklebust@hammerspace.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On 2 Feb 2020, at 17:53, Trond Myklebust wrote:

> Now that the page cache locking is repaired, we should be able to
> switch to using iterate_shared() for improved concurrency when
> doing readdir().
>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>  fs/nfs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 60387dec9032..803e6fec0266 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -58,7 +58,7 @@ static void nfs_readdir_clear_array(struct page*);
>  const struct file_operations nfs_dir_operations = {
>  	.llseek		= nfs_llseek_dir,
>  	.read		= generic_read_dir,
> -	.iterate	= nfs_readdir,
> +	.iterate_shared	= nfs_readdir,
>  	.open		= nfs_opendir,
>  	.release	= nfs_closedir,
>  	.fsync		= nfs_fsync_dir,

Jeez, it makes a lot of sense just to use the page lock.  Wish I could have
thought of that a long time ago.  Thanks for this, we'll send it through
some testing, but it looks good to me.

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben