Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 4 Feb 2020 14:17:25 -0500
From:   Bruce Fields <bfields@fieldses.org>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     linux-rdma@vger.kernel.org,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3] nfsd: Fix NFSv4 READ on RDMA when using readv
Message-ID: <20200204191725.GA10811@fieldses.org>
References: <20200201195914.12238.15729.stgit@bazille.1015granger.net>
 <20200204172154.GB8763@fieldses.org>
 <B95D88FC-C76D-42A2-9366-CA226757BA42@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B95D88FC-C76D-42A2-9366-CA226757BA42@oracle.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 04, 2020 at 01:43:56PM -0500, Chuck Lever wrote:
> 
> 
> > On Feb 4, 2020, at 12:21 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > 
> > On Sat, Feb 01, 2020 at 03:05:19PM -0500, Chuck Lever wrote:
> >> Changes since RFC2:
> >> - Take Trond's suggestion to use xdr->buf->len
> >> - Squash fix down to a single patch
> > 
> > I liked them better split out.
> > 
> > This seems fine to me, though.
> > 
> > Could you ping me again in another week, after the merge window?
> > 
> >> @@ -3521,17 +3521,14 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> >> 	u32 zzz = 0;
> >> 	int pad;
> >> 
> >> +	/* Ensure xdr_reserve_space skips past xdr->buf->head */
> > 
> > Could the comment explain why we're doing this?  (Maybe take some
> > language from the changelog.)
> 
> The new comment will also explain why the patches are combined.
> I'll send a v4 after the merge window closes.

Hah, OK, thanks!

--b.