Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] query_krb5_ccache: Removed dead code that was flagged by
 a covscan
To:     Olga Kornievskaia <aglo@umich.edu>
Cc:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20200207152109.20855-1-steved@redhat.com>
 <CAN-5tyHatMk_xsBW5MHpv7-HyiCMPS9qrz3_O6-XN5KpH_RWtA@mail.gmail.com>
From:   Steve Dickson <SteveD@RedHat.com>
Message-ID: <17f9e558-ed00-c377-83b1-9769fd698cc9@RedHat.com>
Date:   Sat, 8 Feb 2020 04:21:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <CAN-5tyHatMk_xsBW5MHpv7-HyiCMPS9qrz3_O6-XN5KpH_RWtA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


On 2/7/20 12:25 PM, Olga Kornievskaia wrote:
> On Fri, Feb 7, 2020 at 10:22 AM Steve Dickson <steved@redhat.com> wrote:
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>>  utils/gssd/krb5_util.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
>> index bff759f..a1c43d2 100644
>> --- a/utils/gssd/krb5_util.c
>> +++ b/utils/gssd/krb5_util.c
>> @@ -1066,8 +1066,6 @@ query_krb5_ccache(const char* cred_cache, char **ret_princname,
>>                             *ret_realm = strdup(str+1);
>>                     }
>>                     k5_free_unparsed_name(context, princstring);
>> -               } else {
>> -                       found = 0;
>>                 }
> 
> Uhm, sorry wasn't fast enough for you commit decision but I don't see
> that this a dead code? krb5_unparse_string() could return an error so
> "else" is a valid condition. I mean it's probably unlikely that
> check_for_tgt() returns found and they you can't parse the principal
> name out of it. But things like memory errors could still be valid
> error conditions?
Sorry for being so quick with the commit... 

The covscan complained "warning: Value stored to 'found' is never read"
which was true... after setting found = 0, found was never used. 

Yes, the "else" is a valid condition but not necessary since
setting 'found' to zero does not do anything... 

steved.

> 
> 
>>         }
>>         krb5_free_principal(context, principal);
>> --
>> 2.24.1
>>
>