Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Feb 2020 11:46:05 +0100
From:   Patrick Steinhardt <ps@pks.im>
To:     linux-nfs@vger.kernel.org
Subject: Changed fstype for nfs4 mounts starting with 5.6-rc1 (bisected)
Message-ID: <20200218104605.GA281780@ncase>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi"
Content-Disposition: inline
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

starting with v5.6-rc1, I've noticed that my shutdown scripts do not
work properly anymore in case there's any NFS4 mounts present. The issue
stems from an fstype change: while NFS4 mounts previously had fstype
"nfs4", they now have type "nfs". As a result, my "umount -at nfs4"
doesn't do anything, resulting in a hang later on.

While this can trivially be fixed on my side by doing "umount -at
nfs,nfs4", I guess that this was an involuntary change. A bisect points
to commit f2aedb713c28 (NFS: Add fs_context support., 2019-12-10).
Reproducer:

    $ mount.nfs4 host:/mnt /mnt
    $ findmnt -otarget,source,fstype /mnt
    TARGET SOURCE    FSTYPE
    /mnt   host:/mnt nfs

Patrick

--6c2NcOVqGQ03X4Wi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl5LwGsACgkQEXxntp6r
8SzE7Q/+Ki92l3c4wqdfw4djuhZ479YK9wdQNUIjAYR9cuVJ17293JGtYQp16rd1
fxqRnnkYT8yLSXFVFIO+d185NpULdQZwQClGnpcISfZeY7sDzrXLDNhzIBEOKzPK
rV4CPlz59oPwvFpzAjl9iPkylffp6+FQ61v24cYbnah5botxpJ6XRXOsr1kBJAOf
Jvsu9l9U5xA05k0dUvnjCQ7J+rYst6wRerXpAJQUG23H5C6zlMEyuzsRNp4JFS6V
19ZtfMAiDHjGKdXxxP8LqVK2QBpRNeMlePmdLjzVztUq+pc2WFj5ZadEYQozwfP+
SWm67N3sbgLRzsIufc7Yl4Zg0GZsYQgXELtO7Hn1rF/3SDocoL/LsSUri+NWgV/N
5Zc0JevHuZmsYmS9i9JEhbfPL+NVyF88kVxW6e8rZrNLasJL423bQntit1WYrLuE
6ShTTdUZA/mx4a2jSRYFqtjsCT1a1T1230C4tXbXDxmOfN9Xpw7lcigUufzBCY+x
m9cRBJHm06ErcwNCKpr716tgWk578EyBEHMxzNkos/ja05Nwd/8F5PU2AM9jNZKQ
XrWqJRWk+VcgRjwvQqDyk5idQjHc3a3U/ApNGC5nwO9GcKz+MxAB0kdlp6XshVe2
/WPwtTUVP8CYSt8XZCmr4dfNKdHq434VKb1g8yEA9J8ffnF9fjA=
=+N7C
-----END PGP SIGNATURE-----

--6c2NcOVqGQ03X4Wi--