Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1075281ybh; Tue, 10 Mar 2020 14:08:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtvI+LM8chI3dph3fCYuRLqIE7CAQvsdkzfvz5PVYHFeyeNLmyq7AKsq8oWs9rI8OR/jwfU X-Received: by 2002:a54:468a:: with SMTP id k10mr2731797oic.3.1583874486366; Tue, 10 Mar 2020 14:08:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583874486; cv=none; d=google.com; s=arc-20160816; b=GrIBMH11v/6NDjorOB8a5nW76FCJepyx+jCjyy4D5CrEOqvJi5LMdtJcn3TkjOE741 xuGOu3R/sWm9tvOhMj+qUo2V8dusEtQDiv8PruMUYXI9bSDPaMXxkdN0zU3eXgLJIKPS lRBh1OXF2oWFTJQjrvycb91365je93RzspArjQHoR6LBScTwCsrjwEjXZpRACLoE4qDa FXlek3mNOUZYE/3+KBGBHq1TKi/WtPp0FU6x+0IOSvsop1MJpyvhAjdtuJ8VUBNT+fai bqB97LVin6v0bYFwvDRy0ahe4u7btddu0YKVTTmDhIxFBMzyuvWJjWQ7/7Xn//RVj+Lc VZeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=8LD0rZ5gJpLakusKiBQ+8Gh43Qcvt0uYOgV2fLb4ChI=; b=HFDI7vMLbb8Awy/b9fSlA+7M2hqG2cBDxfML8PfbbysGNnJcBbbkxjpitkDp8xvE4i gd1eMh9Z8opy3UoG66Okr9SAAVoCg7AsgbJSRB9e2OHO2V8ZUV1lwMd7S0wz8ZPcm9p1 1syhDmSdJauqIrgBJHxXVLzQCgUPj5/G1o4WbH7jut1GJP5e879kGRLAH+rp+hnWUCtj Y7vlS1O6mmivzOHGNkORXo2cW9MaQ9nZSGcAgiYAerLpoo+8lV/UIC1OH7zjuns6slja lEEiwV9Rjd+JlmOgbpXFbGgTdBbLUX2N6GnqTF0YxMqnDAUldzymkrvuppynrZS+Qgt6 6fiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VSxML8CZ; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q25si3822928ota.36.2020.03.10.14.07.43; Tue, 10 Mar 2020 14:08:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VSxML8CZ; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbgCJVGR (ORCPT + 99 others); Tue, 10 Mar 2020 17:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:40586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbgCJVGR (ORCPT ); Tue, 10 Mar 2020 17:06:17 -0400 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36E4A227BF; Tue, 10 Mar 2020 21:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583874376; bh=vhxZrp2Lx5DeATCenHy71j1LATXknii/r2+vE+Yb5m0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VSxML8CZIv6TujbXRjRw9Ndm8hswQ0Iy4czB2jk6b7uVrcoP7w2FT3QpRGHO/Gfw8 1PAC8sWmIxLgfBwLT0IoBg95GgOQJewHjIgNWqAF9o7XsmOF2nFAtuL0aHnkZz6PQW ByM8dtKGpYIidv0mnusE83YjNVcG4UXW3V9qqpcY= Received: by mail-lf1-f54.google.com with SMTP id i10so12136173lfg.11; Tue, 10 Mar 2020 14:06:16 -0700 (PDT) X-Gm-Message-State: ANhLgQ04zCsRs7UK9XWxVx7wooYAdDNSM9b0I0WQv78AILIpGR7hrwLU Mm1oEeT5RNcvNoUsZ/IhpxOsvFDGqis7tSd4obw= X-Received: by 2002:ac2:554d:: with SMTP id l13mr39638lfk.82.1583874374294; Tue, 10 Mar 2020 14:06:14 -0700 (PDT) MIME-Version: 1.0 References: <20200223165724.23816-1-mcroce@redhat.com> In-Reply-To: <20200223165724.23816-1-mcroce@redhat.com> From: Song Liu Date: Tue, 10 Mar 2020 14:06:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] block: refactor duplicated macros To: Matteo Croce Cc: linux-block@vger.kernel.org, open list , linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org, linux-raid , linux-mmc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, Jens Axboe , "James E.J. Bottomley" , Ulf Hansson , Anna Schumaker Content-Type: text/plain; charset="UTF-8" Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sun, Feb 23, 2020 at 8:58 AM Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce > --- > block/blk-lib.c | 2 +- > drivers/block/brd.c | 3 --- > drivers/block/null_blk_main.c | 4 ---- > drivers/block/zram/zram_drv.c | 8 ++++---- > drivers/block/zram/zram_drv.h | 2 -- > drivers/dax/super.c | 2 +- > drivers/md/bcache/util.h | 2 -- > drivers/md/dm-bufio.c | 6 +++--- > drivers/md/dm-integrity.c | 10 +++++----- > drivers/md/md.c | 4 ++-- > drivers/md/raid1.c | 2 +- > drivers/mmc/core/host.c | 3 ++- > drivers/scsi/xen-scsifront.c | 4 ++-- > fs/iomap/buffered-io.c | 2 +- > fs/nfs/blocklayout/blocklayout.h | 2 -- > include/linux/blkdev.h | 4 ++++ > include/linux/device-mapper.h | 1 - > 17 files changed, 26 insertions(+), 35 deletions(-) For md: Acked-by: Song Liu