Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20200313123957.6122-1-pvorel@suse.cz>
Date:   Fri, 13 Mar 2020 10:41:44 -0400
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Bruce Fields <bfields@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5A8BA7E5-C24D-4FA6-9D4B-1216398CDF38@oracle.com>
References: <20200313123957.6122-1-pvorel@suse.cz>
To:     Petr Vorel <pvorel@suse.cz>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Mar 13, 2020, at 8:39 AM, Petr Vorel <pvorel@suse.cz> wrote:
>=20
> It's meant to be read only.
>=20
> Fixes: 89c905beccbb ("nfsd: allow forced expiration of NFSv4 clients")
>=20
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>=20
> does not really fix anything, it's just confusing to have read
> permission bit when not used.

Hi Petr, applied to nfsd-5.7-testing, with the patch description =
corrected
to read:

"It's meant to be write-only."


> Kind regards,
> Petr
>=20
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 65cfe9ab47be..475ece438cfc 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2636,7 +2636,7 @@ static const struct file_operations =
client_ctl_fops =3D {
> static const struct tree_descr client_files[] =3D {
> 	[0] =3D {"info", &client_info_fops, S_IRUSR},
> 	[1] =3D {"states", &client_states_fops, S_IRUSR},
> -	[2] =3D {"ctl", &client_ctl_fops, S_IRUSR|S_IWUSR},
> +	[2] =3D {"ctl", &client_ctl_fops, S_IWUSR},
> 	[3] =3D {""},
> };

--
Chuck Lever