Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] nfsd4: kill warnings on testing stateids with mismatched
 clientids
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <A2752AC8-E6FF-4ED7-86BE-4D64ACE1F7D7@redhat.com>
Date:   Thu, 19 Mar 2020 10:59:56 -0400
Cc:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <88C0AB03-E10D-40D2-BDB6-3185D099C192@oracle.com>
References: <20200319141849.GB1546@fieldses.org>
 <A2752AC8-E6FF-4ED7-86BE-4D64ACE1F7D7@redhat.com>
To:     Benjamin Coddington <bcodding@redhat.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Mar 19, 2020, at 10:30 AM, Benjamin Coddington =
<bcodding@redhat.com> wrote:
>=20
> On 19 Mar 2020, at 10:18, J. Bruce Fields wrote:
>=20
>> From: "J. Bruce Fields" <bfields@redhat.com>
>>=20
>> It's normal for a client to test a stateid from a previous instance,
>> e.g. after a network partition.
>>=20
>> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>=20
> Thanks!
>=20
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Applied to nfsd-5.7, thanks all!


> Ben
>=20
>> ---
>> fs/nfsd/nfs4state.c | 9 +--------
>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>=20
>> I'm not a fan of printk's even on buggy client behavior.  I guess it
>> could be a dprintk.  I'm not sure it adds much over information you
>> could get at some other layer, e.g. from a network trace.
>>=20
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index c1f347bbf8f4..927cfb9d2204 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -5522,15 +5522,8 @@ static __be32 nfsd4_validate_stateid(struct =
nfs4_client *cl, stateid_t *stateid)
>> 	if (ZERO_STATEID(stateid) || ONE_STATEID(stateid) ||
>> 		CLOSE_STATEID(stateid))
>> 		return status;
>> -	/* Client debugging aid. */
>> -	if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid)) {
>> -		char addr_str[INET6_ADDRSTRLEN];
>> -		rpc_ntop((struct sockaddr *)&cl->cl_addr, addr_str,
>> -				 sizeof(addr_str));
>> -		pr_warn_ratelimited("NFSD: client %s testing state ID "
>> -					"with incorrect client ID\n", =
addr_str);
>> +	if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid))
>> 		return status;
>> -	}
>> 	spin_lock(&cl->cl_lock);
>> 	s =3D find_stateid_locked(cl, stateid);
>> 	if (!s)
>> --=20
>> 2.25.1
>=20

--
Chuck Lever