Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20200319153038.GA2624@fieldses.org>
Date:   Thu, 19 Mar 2020 11:35:08 -0400
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: 7bit
Message-Id: <7B681219-E253-46ED-BDE5-0D0C1606685E@oracle.com>
References: <20200319153038.GA2624@fieldses.org>
To:     Bruce Fields <bfields@fieldses.org>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Mar 19, 2020, at 11:30 AM, bfields@fieldses.org wrote:
> 
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> Userspace should be able to monitor nfsd/clients/ to see when clients
> come and go, but we're failing to send fsnotify events.
> 
> Cc: stable@kernel.org
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Applied to nfsd-5.7, thanks!


> ---
> fs/nfsd/nfsctl.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index e109a1007704..3bb2db947d29 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1333,6 +1333,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
> 	dget(dentry);
> 	ret = simple_rmdir(dir, dentry);
> 	WARN_ON_ONCE(ret);
> +	fsnotify_rmdir(dir, dentry);
> 	d_delete(dentry);
> 	inode_unlock(dir);
> }
> -- 
> 2.25.1
> 

--
Chuck Lever