Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH 11/14] nfsd: add user xattr RPC XDR encoding/decoding
 logic
From:   Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <20200319221350.GA18279@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com>
Date:   Thu, 19 Mar 2020 18:15:19 -0400
Cc:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1C99F4A1-4868-43C2-9F36-25FA5D82B92E@oracle.com>
References: <20200311195954.27117-1-fllinden@amazon.com>
 <20200311195954.27117-12-fllinden@amazon.com>
 <17D7709F-2FE0-4B84-A9AF-4D6C2B36A4E7@oracle.com>
 <20200319221350.GA18279@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com>
To:     Frank van der Linden <fllinden@amazon.com>
Sender: linux-nfs-owner@vger.kernel.org
Precedence: bulk


> On Mar 19, 2020, at 6:13 PM, Frank van der Linden =
<fllinden@amazon.com> wrote:
>=20
> On Thu, Mar 12, 2020 at 12:24:18PM -0400, Chuck Lever wrote:
>>> +static inline u32 nfsd4_getxattr_rsize(struct svc_rqst *rqstp,
>>> +                                    struct nfsd4_op *op)
>>> +{
>>> +     u32 maxcount, rlen;
>>> +
>>> +     maxcount =3D svc_max_payload(rqstp);
>>> +     rlen =3D min_t(u32, XATTR_SIZE_MAX, maxcount);
>>> +
>>> +     return (op_encode_hdr_size + 1 + XDR_QUADLEN(rlen)) * =
sizeof(__be32);
>>=20
>> These should be added in the same patch that adds OP_GETXATTR and =
friends.
>>=20
>> Also, Trond recently added xdr_align_size which I prefer over the
>> use of XDR_QUADLEN in new code.
>=20
> Thanks, I've squashed together those patches for this and the other =
reasons
> you pointed out.
>=20
> As for XDR_QUADLEN: that returns the 32bit-word rounded up lenghth - =
in words.
> xdr_aligned_size returns the 32bit-word rounded up length - in bytes.
>=20
> So, the result would then look something like:
>=20
> 	return xdr_align_size((op_encode_hdr_size * 4) + 4 + rlen);
>=20
> Is that what you're suggesting?

Oops, you're right. When you want words, XDR_QUADLEN is correct. Never =
mind!


--
Chuck Lever