Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4906047ybb; Tue, 24 Mar 2020 07:29:20 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvXvhA1cfXCmN754q4BQcpXJEC4x/S8gBtZTKlvxPSYsGS0e3Yyyz8I8NKAmaI0y+UpWRjp X-Received: by 2002:a4a:8604:: with SMTP id v4mr2021638ooh.82.1585060159862; Tue, 24 Mar 2020 07:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585060159; cv=none; d=google.com; s=arc-20160816; b=mEAHzIYCZpjKlijnYSI4V2rfv0+WDZz/Hkq6kOFU/49ypSfSa2qYnHFr1oOvXwlliH eCNxj2an0Dy7SODpabAx6s1JrJD9mHa/P3wEesp5JCiMbKiZC/kvBXTkF/XLA2XJIPUp ITIlbINWuBalHNU1rPb1gpfNiMp78LiV+6EzKPGzUp2OuvBA4Ou2hUthwg53W0mx8P1a EpQrtHZBd9COg2PwfvHjm39jKcMDkg6FcGm0vZwljlhs6awPgXhE/GCzD6z83oh0DlIB 5UNj/b6b8IXBXk5mfjveMuiRtDpaqGBqg/fhHYmObtkYuWTa9RutMfSoRwetrlvlwyqo WxHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=r0b04Ri7hNdDUSPoo3dfkRqOsI0J4us/2FuapcKe78w=; b=grXGSuALhaDT+8Hqeqdiy3ljHoJZMlUL0AxUzWeoKR+rQpxbFmzn58uS10SX1CcOZU 6g2GZ+UGSEUtxcz/KK6VTTAV9YQYqksFgfpSU29wZPuG3RBkvcNX/Qv1hYPKLWhd0gCq UAZsVMvayr5zulxQHWSoPqrjss2pJwgMDySmhWYfDs0TdPsSNGtIf6qbLzPLYbZDpBHr mNJCSb63UKJjQTRjK9KPkrcRsG6+fOCFVM9uK8/9hpUWgwPha+lCsz8oWgqtkp8A9S9r VCQav7RDd0MQbtBOHzevIiuvVw8u00ek0Bc+MB4bYnlnFZ7x4jNgdeVqbZUqBMJVy4VB zq5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p26si9415307oth.186.2020.03.24.07.29.05; Tue, 24 Mar 2020 07:29:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbgCXO3D (ORCPT + 99 others); Tue, 24 Mar 2020 10:29:03 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:60030 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727382AbgCXO3D (ORCPT ); Tue, 24 Mar 2020 10:29:03 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R721e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04397;MF=wuyihao@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0TtX8sph_1585060130; Received: from Macintosh.local(mailfrom:wuyihao@linux.alibaba.com fp:SMTPD_---0TtX8sph_1585060130) by smtp.aliyun-inc.com(127.0.0.1); Tue, 24 Mar 2020 22:28:50 +0800 Subject: Re: [PATCH] nfsd: fix race between cache_clean and cache_purge To: Chuck Lever Cc: Bruce Fields , Linux NFS Mailing List References: <5eed50660eb13326b0fbf537fb58481ea53c1acb.1585043174.git.wuyihao@linux.alibaba.com> <91F74983-D681-4CD3-92FF-8CDB8DB7CD8D@oracle.com> From: Yihao Wu Message-ID: <709608a5-24e6-d279-ef3a-ff9ab7538f88@linux.alibaba.com> Date: Tue, 24 Mar 2020 22:28:49 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <91F74983-D681-4CD3-92FF-8CDB8DB7CD8D@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 2020/3/24 10:18 PM, Chuck Lever wrote: >> Fixes: 471a930ad7d1(SUNRPC: Drop all entries from cache_detail when cache_purge()) >> Cc: stable@vger.kernel.org #v4.11+ > Yihao, I couldn't get this patch to apply to kernels before v5.0. > > I don't think we need both a Fixes tag and a Cc: stable, because > stable maintainers will try to apply this patch to any kernel that > has 471a930, and ignore the failures. > > So if I apply your fix, I'm going to drop the Cc: stable tag. > > OK. And thanks for reviewing and reminding me this, Chuck. Yihao Wu