Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4911314ybb; Tue, 24 Mar 2020 07:34:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv03l2TBEvc8BS9HVE0U+4iIgOxnz3cjW+JxfmLQ+pDCn0Lg7mPiYMTPpa9vM+vcuTw9U+u X-Received: by 2002:aca:5454:: with SMTP id i81mr3677279oib.23.1585060479813; Tue, 24 Mar 2020 07:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585060479; cv=none; d=google.com; s=arc-20160816; b=xwbJdpBwtTeT0VL+6jhC4RrgReDJKPRbVI9N3+rMYTOSwzwIhc3ZgdejazaNQvDIHw 42tyrlH1YG0dVY1QoK27orAMt1f49v9KkT0lfmSwlw2lM7wG9MHS9KA2p5JY+ohb63MM Q/zyl+9jcEqXiYEc4Ag7zLeiSQ69SE2EQflw2sjuBzQvtCk4NrZvxiKSCV7ExOZJlF0g j8MMjqnv41B5r6Tnxibo8OVIBNdn0Ay9l6zhRWxzSB0gacU3814TbAblgDPj8oZzB158 7iDUu1r7OQUSHlsuKmDl3ARVmbSVbeR5WQsIHpWwuOBda0NXKiqOPfwDfKvg8VdLEPXb 7hvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6OG4UbVD+fzLeFgtxlzKknwDkocaj4lMxKpnYoYvQ7A=; b=tzEPpINbJGzP/1PmRAxdqq37fZT3KLBDrMoKQ0T6DF46ll10Y3DGN1r7ViP+epIERY HHjgFcGDQBgrv2OVxewmIXYor2SvX08GMaQaI1IRXBvHPIsnaAl9Fi7v05TpEBCNhBYx j3pZ77+qw7QLnSvDqN3qAkrNVcpA1SzQSePNBXu+WGzk4+wfOCsjaioKD5uR+Pt7j8Wm xv2yvru0FbqqVXoFrrbhz0bjT/OuXFPXpsOKQSmGWxG8HrBl9dct6pgYL/2KDeyuo10m 9z4Yxx/C0A4dn2GahVUUOkWl8poEkzyAAUcFLtuPk3ZerpmDCt/7ii6EhNz8S5xDFifJ ozyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si9271488otn.56.2020.03.24.07.34.26; Tue, 24 Mar 2020 07:34:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgCXOd4 (ORCPT + 99 others); Tue, 24 Mar 2020 10:33:56 -0400 Received: from fieldses.org ([173.255.197.46]:53156 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgCXOd4 (ORCPT ); Tue, 24 Mar 2020 10:33:56 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 34B18201A; Tue, 24 Mar 2020 10:33:56 -0400 (EDT) Date: Tue, 24 Mar 2020 10:33:56 -0400 From: Bruce Fields To: Chuck Lever Cc: Trond Myklebust , NeilBrown , Linux NFS Mailing List , Yihao Wu Subject: Re: [PATCH] nfsd: fix race between cache_clean and cache_purge Message-ID: <20200324143356.GA11065@fieldses.org> References: <5eed50660eb13326b0fbf537fb58481ea53c1acb.1585043174.git.wuyihao@linux.alibaba.com> <8B2BC124-6911-46C9-9B01-A237AC149F0A@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8B2BC124-6911-46C9-9B01-A237AC149F0A@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Mar 24, 2020 at 09:38:55AM -0400, Chuck Lever wrote: > Mechanically this looks OK, but I would feel more comfortable > if a domain expert could review this. Neil, Trond, Bruce? Looks right to me. Reviewed-by: J. Bruce Fields --b.