Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4913116ybb; Tue, 24 Mar 2020 07:36:33 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtNYi9K5SSxy3aTACIlahLfP75mPED4qbkCLH4W9TqyXP307ul+6mK6OG2VZgyaUJQTG/az X-Received: by 2002:a05:6830:1e10:: with SMTP id s16mr6294370otr.33.1585060592968; Tue, 24 Mar 2020 07:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585060592; cv=none; d=google.com; s=arc-20160816; b=kkJZJQd/UilyYd29q5wihkwilYGleO1T5z3Oi2ZG6xlX/LsihiltFhQ7D0illc7/iv uO+KNcGUnd2hI+L+lwdHzsamyP0zMnhPVtCojjkM5mCBRTlQ7hrHsHnueMpPxK8NGcVW C7ssfxxhMQdzh73TCwBT92sOiglWzc2NWduNl1y6YivDA/cSlR1/Z/Ufh509rvJtRKaM untyaeqOP/p7qFEKWBID8BK4NBRNCok2R0UMpCv/Ra91kvrARjgZ1on5qJcnWg6pxV/F wGMrFB9tK2A85fBuWcrBBs0qlCCiy3l/qe0mZJpsvMWOJfhLZmg6iRwr4lF/+a2xYf6b KovA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=uvDrFvOPKAtLVLthlbJ7GLpS4M2BczAcaaNrTynzHec=; b=bCksT7zwu+u3inHB6/+6p8iBCZE3phL6OlPHvUd3wexMIqK6xExxuN62gy8kjImXqH e3A8j0OdT4AMIsi3OIK7FIYy36zQg/CeyAtRM4TI9SWd7uXDjTI3hdqYO5WsDdXgZUal VDqfb9XP5XLfQDq6YzPXiC3BTyL2r0wDhlIN4WecvU5lemsn4YR8CkrGudAYDxyJYhHF V6AO5Vyc2iGt+grD0ZuXDW5K1nUVSV5lPSfnlh+7Nq/rXxwVdalCUEhCHnGJOdckl0L5 /zTToHXLbPrYSSEqNY5wycHNqH1EAkv2rc0IxYSFXesYxCEkQXOTLccVf1QLWU3sVchp tYZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=mpfaXWPl; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t140si9355873oif.99.2020.03.24.07.36.20; Tue, 24 Mar 2020 07:36:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=mpfaXWPl; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgCXOfw (ORCPT + 99 others); Tue, 24 Mar 2020 10:35:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:50334 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgCXOfv (ORCPT ); Tue, 24 Mar 2020 10:35:51 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02OEX21B065800; Tue, 24 Mar 2020 14:35:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=uvDrFvOPKAtLVLthlbJ7GLpS4M2BczAcaaNrTynzHec=; b=mpfaXWPlfyUjOrj+EWJmgXVZ+r0XMZ9Y+NzzlcvfytOXm2xhS2kNtiI9HKp/KmgwOXYp 5xaq2u6BAurfYebap0yzoSQPjBrARXkrNQzMdBal2J8WzteVtcRJctGMFZ4iQH1xPziJ PT+XLJvWINcIlH0DXae27ne83hbrbLRWlhOfhIuVdFBMcrwDY3ALrpPRWT4vq9bXV54v ZuYI2Itff6+4rUqb+6+XaSwZcIEx5bOLgy+2k5pDLB7wZt+KwB/hwS6xDGui9hz7wleg vrYmzYvis9rxf9FuEBPvA+CEBK5jN/yaWv218K/rmUkvL2aNQWExGiU2aNfmqIoWDjNW fw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2ywavm4n08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Mar 2020 14:35:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02OEWGdx144132; Tue, 24 Mar 2020 14:35:39 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2yxw4pdemv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Mar 2020 14:35:39 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02OEZbsN005282; Tue, 24 Mar 2020 14:35:38 GMT Received: from anon-dhcp-153.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Mar 2020 07:35:37 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] nfsd: fix race between cache_clean and cache_purge From: Chuck Lever In-Reply-To: <20200324143356.GA11065@fieldses.org> Date: Tue, 24 Mar 2020 10:35:36 -0400 Cc: Trond Myklebust , NeilBrown , Linux NFS Mailing List , Yihao Wu Content-Transfer-Encoding: 7bit Message-Id: References: <5eed50660eb13326b0fbf537fb58481ea53c1acb.1585043174.git.wuyihao@linux.alibaba.com> <8B2BC124-6911-46C9-9B01-A237AC149F0A@oracle.com> <20200324143356.GA11065@fieldses.org> To: Bruce Fields X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=818 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003240079 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 mlxlogscore=880 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003240079 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Mar 24, 2020, at 10:33 AM, Bruce Fields wrote: > > On Tue, Mar 24, 2020 at 09:38:55AM -0400, Chuck Lever wrote: >> Mechanically this looks OK, but I would feel more comfortable >> if a domain expert could review this. Neil, Trond, Bruce? > > Looks right to me. > > Reviewed-by: J. Bruce Fields Thanks, Bruce! I've added your R-b. -- Chuck Lever