Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp658488ybb; Wed, 25 Mar 2020 07:13:59 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsBry7/2sCe5JPedL+mrz0aflQ4jjXGfNL60exukb1I6oLyuP3O48wMNp8qpkn8lKfC0FPR X-Received: by 2002:aca:6184:: with SMTP id v126mr2516105oib.168.1585145639070; Wed, 25 Mar 2020 07:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585145639; cv=none; d=google.com; s=arc-20160816; b=muzYG0180/w2P8g7ahpb6yeDp13wk5kukJs+BiZcGR0wM9fmiz82mbP2TLoCWLn4XJ DDvLu2z+UWfuAAwrBzKHFqgNK32BtC6+T5iq2Wy8s11qmIYRb4ibTm5hmBuk9weqoXGo ErkhnThJAc1xx3rGPFJvIwUJehe3jO7ErV2NUsizh+EfoGS0gzWCrGB4LoZiMPn+NYyv 9kbiR6nKJ+5NCo29X9o5jNI3RAIOgDJ570bp4s2E+BkAsu1UI3t0VXDrkvx20hOhc7m0 cfKhdb3qLyWZwQ7w+HZPdBXgVTY4utSLaWiYS2+mMt9OxANjZrnIICgMa7PgHEJ5u4jP EC4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=Dcv6XiWIA3FWI0oL0yKD6E+jKrRuAaHzTaE1NeIMyi8=; b=lcYLoklewaKPOnkOFA6i+fE2VzAEwElmxJcRdaYoOG4E9Cki3EiFoxKBIuu+K2unmg zc0Bxw+E13nd2EOMnwmc36BAPoWPo8VTugnKmu4fvSz9nb+km0L69uucn2o1a/ROAlp6 1I7jNIoZRHItpTsTmu/+iWYzCIx09IEuz7PAhrICuoV8FBvUlf6ruw+sUVeSKnolZeLv 3Vp89St4rMcunTAIbwT90OcbP5iDoCBayJAOo/ycDKEVUpDA0vqLhVbKw/ajfKSezdmD Mc+DxJ8TZudoZ+LfnrBHiYrD559S1zUDo9iDJzn3Phj6cCJB54kyiM7bVSYdi5hm4xMi XVwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=0See8Jr5; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x35si3375268otb.99.2020.03.25.07.13.41; Wed, 25 Mar 2020 07:13:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=0See8Jr5; spf=pass (google.com: best guess record for domain of linux-nfs-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727627AbgCYON2 (ORCPT + 99 others); Wed, 25 Mar 2020 10:13:28 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:48820 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727595AbgCYON1 (ORCPT ); Wed, 25 Mar 2020 10:13:27 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PE9GTe127381; Wed, 25 Mar 2020 14:13:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=Dcv6XiWIA3FWI0oL0yKD6E+jKrRuAaHzTaE1NeIMyi8=; b=0See8Jr5jzce6bXEMUJh7uLmi9Jjt+SAu9wc33sqntNdRg/dHY7zapEiFszatyCPiZCh EIzqs0F8MfmJW4MsDMcikLCpI8V1yRjATM2H0sl10Ch1aP7rVnQpLz4Rr0u8OiU99WrH 3qQi5N7bzpMIfOQsuT72VwL3ML4c06cnEOxx6rQsxc5LKigTXkhuR9+dztAbRbtzmziG cH5bBSdEPQbFIz9l9rDiYDhhWDzXkqkeq1X2+8Uez6ujj/BboDWdUs2h1nOiStQvc76W op9diZlyX/vn5DNokECqmJV17tWaLkLLZMpSM28q/wBnKwMZJiHQgfR1hkJ8UWbeap+W og== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2ywavm9xxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 14:13:12 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PE7cl0117867; Wed, 25 Mar 2020 14:13:12 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 3003ght3y3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 14:13:12 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02PED9XG030912; Wed, 25 Mar 2020 14:13:10 GMT Received: from anon-dhcp-153.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Mar 2020 07:13:09 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH] nfsd: fix race between cache_clean and cache_purge From: Chuck Lever In-Reply-To: <20200325010158.81CD12074D@mail.kernel.org> Date: Wed, 25 Mar 2020 10:13:08 -0400 Cc: Yihao Wu , Bruce Fields , Linux NFS Mailing List , stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <6C811CEE-8FC8-46D1-8E64-BE667138C43D@oracle.com> References: <5eed50660eb13326b0fbf537fb58481ea53c1acb.1585043174.git.wuyihao@linux.alibaba.com> <20200325010158.81CD12074D@mail.kernel.org> To: Sasha Levin X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9570 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 suspectscore=2 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9570 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 bulkscore=0 clxscore=1011 impostorscore=0 phishscore=0 suspectscore=2 mlxlogscore=999 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250117 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Mar 24, 2020, at 9:01 PM, Sasha Levin wrote: >=20 > Hi >=20 > [This is an automated email] >=20 > The bot has tested the following trees: v5.5.11, v5.4.27, v4.19.112, = v4.14.174, v4.9.217, v4.4.217. >=20 > v5.5.11: Build OK! > v5.4.27: Build OK! > v4.19.112: Failed to apply! Possible dependencies: > 1863d77f15da ("SUNRPC: Replace the cache_detail->hash_lock with a = regular spinlock") >=20 > v4.14.174: Failed to apply! Possible dependencies: > 1863d77f15da ("SUNRPC: Replace the cache_detail->hash_lock with a = regular spinlock") >=20 > v4.9.217: Failed to apply! Possible dependencies: > 1863d77f15da ("SUNRPC: Replace the cache_detail->hash_lock with a = regular spinlock") > 2b477c00f3bd ("svcrpc: free contexts immediately on PROC_DESTROY") > 471a930ad7d1 ("SUNRPC: Drop all entries from cache_detail when = cache_purge()") >=20 > v4.4.217: Failed to apply! Possible dependencies: > 1863d77f15da ("SUNRPC: Replace the cache_detail->hash_lock with a = regular spinlock") > 2b477c00f3bd ("svcrpc: free contexts immediately on PROC_DESTROY") > 471a930ad7d1 ("SUNRPC: Drop all entries from cache_detail when = cache_purge()") > d8d29138b17c ("sunrpc: remove 'inuse' flag from struct = cache_detail.") >=20 >=20 > NOTE: The patch will not be queued to stable trees until it is = upstream. >=20 > How should we proceed with this patch? Please drop it. Thanks! -- Chuck Lever